Skip to content

[BEAM-11363] Create :sdks:java:extensions:ml:integrationTest target, run in Java PostCommit #13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennknowles merged 1 commit into from
Dec 3, 2020
Merged

[BEAM-11363] Create :sdks:java:extensions:ml:integrationTest target, run in Java PostCommit #13444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ task javaPostCommit() {
dependsOn ":sdks:java:extensions:zetasketch:postCommit"
dependsOn ":sdks:java:io:google-cloud-platform:postCommit"
dependsOn ":sdks:java:io:kinesis:integrationTest"
dependsOn ":sdks:java:extensions:ml:postCommit"
dependsOn ":javaHadoopVersionsTest"
dependsOn ":sdks:java:io:kafka:kafkaVersionsCompatibilityTest"
}
Expand Down
33 changes: 26 additions & 7 deletions sdks/java/extensions/ml/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,30 @@ dependencies {
testRuntimeOnly project(":runners:google-cloud-dataflow-java")
}

project.test {
def gcpProject = project.findProperty("gcpProject") ?: 'apache-beam-testing'
include "**/**IT.class"
def pipelineOptions = [
"--project=${gcpProject}"
]
systemProperty "beamTestPipelineOptions", JsonOutput.toJson(pipelineOptions)
/**
* These are integration tests with the GCP ML services and the DirectRunner.
*/
task integrationTest(type: Test) {
group = "Verification"
def gcpProject = project.findProperty('gcpProject') ?: 'apache-beam-testing'
def gcpTempRoot = project.findProperty('gcpTempRoot') ?: 'gs://temp-storage-for-end-to-end-tests'
systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
"--runner=DirectRunner",
"--project=${gcpProject}",
"--tempRoot=${gcpTempRoot}",
])

// Disable Gradle cache: these ITs interact with live service that should always be considered "out of date"
outputs.upToDateWhen { false }
Copy link
Member

@kennknowles kennknowles Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to note that "UP-TO-DATE" and "FROM-CACHE" are two different Gradle statuses for a task. I presume if it is never up to date it is also never cached...

Copy link
Member Author

@TheNeuralBit TheNeuralBit Dec 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from

beam/sdks/java/extensions/google-cloud-platform-core/build.gradle

Lines 76 to 77 in c5d5b9a

// Disable Gradle cache: these ITs interact with live service that should always be considered "out of date"
outputs.upToDateWhen { false }

I can update the comments in both places to be more correct - it sounds like just dropping "Disable Gradle cache:" would address it?


include '**/*IT.class'
maxParallelForks 4
classpath = sourceSets.test.runtimeClasspath
testClassesDirs = sourceSets.test.output.classesDirs
}

task postCommit {
group = "Verification"
description = "Integration tests of ML service connectors using the DirectRunner."
dependsOn integrationTest
}