[BEAM-10961] Enabled strict dependency over sdks-io #13688
Conversation
|
@sonam-vend Is there any Jira issue(s) about these "Enabled strict dependency ..." PRs? |
Yes, there is one https://issues.apache.org/jira/browse/BEAM-10961 |
|
Run Java PreCommit |
@sonam-vend Great! Could you add a prefix with Jira ID (like "[BEAM-10961]") to PRs and commit messages? It will allow automatically link a PR with a correspondent Jira issue and make it easier to observe the history of changes in the future. Ptal on this as well: |
sonam-vend
changed the title
| // "spotbugs-annotations:3.1.12" used in Beam. Not required. | ||
| exclude group: "org.apache.zookeeper", module: "zookeeper" | ||
| // "kafka-clients" has to be provided since user can use its own version. | ||
| exclude group: "org.apache.kafka", module: "kafka-clients" |
There was a problem hiding this comment.
For :sdks:java:container:generateLicenseReport to succeed, had to exclude kafka-clients and zookeeper.
|
|
||
| dependencies { | ||
| compile library.java.google_api_services_bigquery | ||
| testImplementation library.java.google_api_services_bigquery |
There was a problem hiding this comment.
No need for compile+permitUnusedDeclared here since this bigquery-io-perf-tests just contains tests.
|
@ibzib do you think this is good to go? |
ibzib
left a comment
ibzib
left a comment
There was a problem hiding this comment.
I'd still prefer this PR to be split up further, with one file per PR (with the exception of kinesis and kinesis/expansion-service, which are fine to put in the same PR if you like). These files are totally unrelated but for the fact that they are IOs, so it will be much easier to review each file separately. Many of these files are ready to merge right now, like in #13902. But when files that are ready to merged are mixed in with files that are not, it becomes very time-consuming to review, since every time I have to re-evaluate which files are ready and which need changes. Plus, it is a lot easier to roll back smaller changes in case we accidentally create a bug.
@ibzib Point well taken. 21 PRs coming up :-) |
|
This PR was broken up and merged in pieces. |
4 participants
Since enabling the strict dependencies on all Java modules is a large and critical change to be merged all at once. Therefore, task [BEAM-10961] is divided into sub-tasks and strict dependencies are enabled to each module separately which is comparatively easy to review and merge.Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.