-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-10961] Enabled strict dependency over sdks-io #13688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
23a1b8d
Enabled strict dependency over sdks-io
sonam-vend 957ef8d
Merge branch 'master' of https://github.com/apache/beam into sdks-io
sonam-vend 2cf3d7b
set enableStrictDependencies=true to sdks-io
sonam-vend dd44bd3
Enabled strict dependency over sdks-io
sonam-vend 7edd9fd
Merge branch 'sdks-io' of https://github.com/sonam-vend/beam into sdk…
shehzaadn-vd 224ac85
move google-cloud-platform changes to a different PR
shehzaadn-vd 5d59cc8
Apply suggestions from code review
shehzaadn-vd e07a255
move amazon-web-services* changes to another PR
shehzaadn-vd bee54fb
moved trivial changes to PR #13794
shehzaadn-vd 06d69ab
undo changes to redis/build.gradle (should have been part of commit b…
shehzaadn-vd 3dce55c
move sdks/java/io/snowflake/build.gradle to its own PR
shehzaadn-vd c4011dc
move sdks/java/io/snowflake/expansion-service/build.gradle to separat…
shehzaadn-vd f8824e7
moved sdks/java/io/hadoop-format/build.gradle to its own PR
shehzaadn-vd 98b1e2d
(1) bring back removed compile lines paired with permitUnusedDeclared…
shehzaadn-vd 9378c68
Merge branch 'master' into sdks-io
shehzaadn-vd dc848cb
[BEAM-10961] add compile lines for usedUndeclared jackson* artifacts
shehzaadn-vd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ import java.util.stream.Collectors | |
|
|
||
| plugins { id 'org.apache.beam.module' } | ||
| applyJavaNature( | ||
| enableStrictDependencies:true, | ||
| automaticModuleName: 'org.apache.beam.sdk.io.kafka', | ||
| mavenRepositories: [ | ||
| [id: 'io.confluent', url: 'https://packages.confluent.io/maven/'] | ||
|
|
@@ -49,6 +50,9 @@ dependencies { | |
| compile library.java.vendored_guava_26_0_jre | ||
| compile project(path: ":sdks:java:core", configuration: "shadow") | ||
| compile project(":sdks:java:expansion-service") | ||
| permitUnusedDeclared project(":sdks:java:expansion-service") | ||
| compile "org.apache.kafka:kafka-clients:2.4.1" | ||
| compile library.java.avro | ||
| // Get back to "provided" since 2.14 | ||
| provided library.java.kafka_clients | ||
| compile library.java.slf4j_api | ||
|
|
@@ -57,6 +61,13 @@ dependencies { | |
| compile library.java.jackson_databind | ||
| compile "org.springframework:spring-expression:4.3.18.RELEASE" | ||
| compile ("io.confluent:kafka-avro-serializer:5.3.2") { | ||
| // zookeeper depends on "spotbugs-annotations:3.1.9" which clashes with current | ||
| // "spotbugs-annotations:3.1.12" used in Beam. Not required. | ||
| exclude group: "org.apache.zookeeper", module: "zookeeper" | ||
| // "kafka-clients" has to be provided since user can use its own version. | ||
| exclude group: "org.apache.kafka", module: "kafka-clients" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For |
||
| } | ||
| compile ("io.confluent:kafka-schema-registry-client:5.3.2") { | ||
| // It depends on "spotbugs-annotations:3.1.9" which clashes with current | ||
| // "spotbugs-annotations:3.1.12" used in Beam. Not required. | ||
| exclude group: "org.apache.zookeeper", module: "zookeeper" | ||
|
|
@@ -71,8 +82,6 @@ dependencies { | |
| // For testing Cross-language transforms | ||
| testCompile project(":runners:core-construction-java") | ||
| testCompile library.java.avro | ||
| testCompile library.java.hamcrest_core | ||
| testCompile library.java.hamcrest_library | ||
| testCompile library.java.junit | ||
| testCompile library.java.powermock | ||
| testCompile library.java.powermock_mockito | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for compile+permitUnusedDeclared here since this bigquery-io-perf-tests just contains tests.