-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Decreasing peak memory usage for beam.TupleCombineFn.
#15271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @robertwb |
Codecov Report
@@ Coverage Diff @@
## master #15271 +/- ##
==========================================
- Coverage 83.86% 83.79% -0.07%
==========================================
Files 441 440 -1
Lines 59724 59804 +80
==========================================
+ Hits 50086 50115 +29
- Misses 9638 9689 +51
Continue to review full report at Codecov.
|
|
retest this please |
1 similar comment
|
retest this please |
|
the failing tests seem to be unrelated |
|
Policy is to merge on green unless its a fix to an issue when there are multiple ongoing issues (e.g. less tests fail then before). |
|
retest this please |
|
Jenkins is happy with this change, |
Revert "Merge pull request #15271 Decreasing peak memory usage for be…
Loading and merging accumulators in batches in
beam.TupleCombineFn.merge_accumulatorsinstead of loading and merging all at once.Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.