Skip to content

Conversation

@iindyk
Copy link
Contributor

@iindyk iindyk commented Aug 3, 2021

Loading and merging accumulators in batches in beam.TupleCombineFn.merge_accumulators instead of loading and merging all at once.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@iindyk
Copy link
Contributor Author

iindyk commented Aug 3, 2021

R: @robertwb

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #15271 (12d624b) into master (7b54b0b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15271      +/-   ##
==========================================
- Coverage   83.86%   83.79%   -0.07%     
==========================================
  Files         441      440       -1     
  Lines       59724    59804      +80     
==========================================
+ Hits        50086    50115      +29     
- Misses       9638     9689      +51     
Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/combiners.py 93.71% <100.00%> (+0.11%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 90.24% <0.00%> (-4.88%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.70% <0.00%> (-4.72%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.47% <0.00%> (-1.39%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.42% <0.00%> (-1.07%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 75.53% <0.00%> (-1.07%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.26% <0.00%> (-0.53%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.33% <0.00%> (-0.38%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b54b0b...12d624b. Read the comment docs.

@iindyk iindyk requested a review from robertwb August 11, 2021 22:22
@iindyk
Copy link
Contributor Author

iindyk commented Aug 17, 2021

retest this please

1 similar comment
@iindyk
Copy link
Contributor Author

iindyk commented Aug 17, 2021

retest this please

@iindyk
Copy link
Contributor Author

iindyk commented Aug 17, 2021

the failing tests seem to be unrelated

@lukecwik
Copy link
Member

Policy is to merge on green unless its a fix to an issue when there are multiple ongoing issues (e.g. less tests fail then before).

@iindyk
Copy link
Contributor Author

iindyk commented Aug 20, 2021

retest this please

@robertwb
Copy link
Contributor

Jenkins is happy with this change,

@robertwb robertwb merged commit 4559c75 into apache:master Aug 24, 2021
ibzib pushed a commit to ibzib/beam that referenced this pull request Aug 26, 2021
…for beam.TupleCombineFn."

This reverts commit 4559c75, reversing
changes made to 7611831.
angoenka added a commit that referenced this pull request Aug 30, 2021
Revert "Merge pull request #15271 Decreasing peak memory usage for be…
ibzib pushed a commit to ibzib/beam that referenced this pull request Aug 30, 2021
…for beam.TupleCombineFn."

This reverts commit 4559c75, reversing
changes made to 7611831.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants