Skip to content

Conversation

@ibzib
Copy link

@ibzib ibzib commented Aug 26, 2021

…am.TupleCombineFn."

This reverts commit 4559c75, reversing
changes made to 7611831.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…for beam.TupleCombineFn."

This reverts commit 4559c75, reversing
changes made to 7611831.
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #15406 (08ebb14) into master (3a5b52c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15406      +/-   ##
==========================================
- Coverage   83.66%   83.64%   -0.02%     
==========================================
  Files         440      440              
  Lines       59995    59981      -14     
==========================================
- Hits        50196    50174      -22     
- Misses       9799     9807       +8     
Impacted Files Coverage Δ
...apache_beam/runners/dataflow/internal/apiclient.py 75.12% <ø> (+0.46%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.59% <100.00%> (-0.12%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.47% <0.00%> (-1.39%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 75.53% <0.00%> (-1.07%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.26% <0.00%> (-0.53%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.33% <0.00%> (-0.38%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec671f4...08ebb14. Read the comment docs.

@ibzib
Copy link
Author

ibzib commented Aug 26, 2021

R: @robertwb cc: @iindyk

The original PR broke some internal tests because of 0 division and mutation checks.

@iindyk
Copy link
Contributor

iindyk commented Sep 10, 2021

sorry for the breakage, sent out a modification with fixes and verified that internal tests pass #15494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants