Skip to content

Conversation

@iindyk
Copy link
Contributor

@iindyk iindyk commented Sep 10, 2021

Loading and merging accumulators in batches in beam.TupleCombineFn.merge_accumulators instead of loading and merging all at once.

This is a modification of 292dc44 with a fix of failing internal tests. The original change was reverted in 8c6ade2.


  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #15494 (fde2fd7) into master (549d138) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15494      +/-   ##
==========================================
+ Coverage   83.75%   83.77%   +0.02%     
==========================================
  Files         443      443              
  Lines       60085    60128      +43     
==========================================
+ Hits        50323    50374      +51     
+ Misses       9762     9754       -8     
Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/combiners.py 93.88% <100.00%> (+0.29%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
sdks/python/apache_beam/pipeline.py 91.66% <0.00%> (ø)
sdks/python/apache_beam/transforms/util.py 95.81% <0.00%> (ø)
...hon/apache_beam/portability/api/beam_fn_api_pb2.py 100.00% <0.00%> (ø)
sdks/python/apache_beam/coders/typecoders.py 94.52% <0.00%> (+0.07%) ⬆️
sdks/python/apache_beam/coders/coders.py 88.58% <0.00%> (+0.59%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.86% <0.00%> (+1.38%) ⬆️
.../python/apache_beam/transforms/periodicsequence.py 98.36% <0.00%> (+1.63%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549d138...fde2fd7. Read the comment docs.

@iindyk
Copy link
Contributor Author

iindyk commented Sep 10, 2021

R: @robertwb

@robertwb
Copy link
Contributor

robertwb commented Sep 10, 2021

It doesn't look like there's an easy way to compare the old and new versions, but 292dc44...iindyk:fde2fd763a4bf7e01810821c8c13e754cec32dad does the job

@robertwb
Copy link
Contributor

Run Python PreCommit

@robertwb robertwb merged commit a44f5d7 into apache:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants