Skip to content

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Aug 16, 2021

…date schema source format "

This reverts commit 9ce826e, reversing
changes made to b20a42e.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…ith update schema source format "

This reverts commit 9ce826e, reversing
changes made to b20a42e.
@pabloem
Copy link
Member Author

pabloem commented Aug 16, 2021

Run Python 3.8 PostCommit

@pabloem
Copy link
Member Author

pabloem commented Aug 16, 2021

r: @lukecwik
cc: @satybald - I'll re-revert this once we merge and make sure it can be admitted in

@pabloem
Copy link
Member Author

pabloem commented Aug 17, 2021

Run Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Aug 17, 2021

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #15337 (9e3db24) into master (af59192) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15337      +/-   ##
==========================================
- Coverage   83.81%   83.81%   -0.01%     
==========================================
  Files         441      441              
  Lines       59773    59770       -3     
==========================================
- Hits        50101    50094       -7     
- Misses       9672     9676       +4     
Impacted Files Coverage Δ
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.50% <50.00%> (-0.09%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 87.80% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.42% <0.00%> (-1.07%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 91.47% <0.00%> (-0.78%) ⬇️
...nners/portability/fn_api_runner/worker_handlers.py 79.44% <0.00%> (-0.35%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.85% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/runners/common.py 88.73% <0.00%> (-0.15%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 89.86% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb8cbb...9e3db24. Read the comment docs.

@pabloem
Copy link
Member Author

pabloem commented Aug 17, 2021

Run Python 3.8 PostCommit

@satybald
Copy link
Contributor

@pabloem before you revert, commit, might I have a review for PR to fix the test?

#15352

@pabloem pabloem closed this Aug 19, 2021
@pabloem pabloem deleted the revert-BEAM-12669 branch August 19, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants