Skip to content

Conversation

@satybald
Copy link
Contributor

Fixes a broken test #15237

Lesson learned: specify TestDirectRunner instead of DirectRunner for integration tests

Command Tested:

pytest --log-cli-level=INFO --test-pipeline-options='--region=us-central1 --experiment=use_beam_bq_sink --runner=TestDirectRunner --project=....' -v apache_beam/io/gcp/bigquery_write_it_test.py

....
=================================================================================== 5 passed, 25 warnings in 127.29 seconds ===================================================================================

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) @pabloem
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@satybald satybald changed the title Satybald/update schema source format v2 Fix broken BQ Integration Test Aug 19, 2021
@satybald
Copy link
Contributor Author

Run Python PreCommit

@satybald
Copy link
Contributor Author

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #15352 (6055eb6) into master (a0fbe00) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15352      +/-   ##
==========================================
+ Coverage   83.80%   83.81%   +0.01%     
==========================================
  Files         441      440       -1     
  Lines       59801    59795       -6     
==========================================
+ Hits        50115    50117       +2     
+ Misses       9686     9678       -8     
Impacted Files Coverage Δ
sdks/python/apache_beam/testing/test_pipeline.py 98.24% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
test_config.py
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.00% <0.00%> (+0.15%) ⬆️
sdks/python/apache_beam/runners/direct/executor.py 96.79% <0.00%> (+0.53%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.86% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c861c89...6055eb6. Read the comment docs.

@pabloem
Copy link
Member

pabloem commented Aug 19, 2021

LGTM. Thanks so much @satybald - I appreciate your fixing this : )

Other failed tests are broken on the master branch.

@pabloem pabloem merged commit 358babb into apache:master Aug 19, 2021
@lukecwik lukecwik changed the title Fix broken BQ Integration Test [BEAM-12765] Fix broken BQ Integration Test Aug 19, 2021
@satybald satybald deleted the satybald/update-schema-source-format-v2 branch August 19, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants