[BEAM-12482] Ensure that we ignore schema update options when loading temporary tables that don't exist. #15635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… temporary tables that don't exist.
Member
Author
|
R: @chamikaramj |
Contributor
|
Do we need something similar to what was done for Python: #14113 |
Member
Author
Yes. This is only a partial fix as in jobs that create the table will work and pushes the error further down the road as per the PR description. |
Contributor
|
LGTM. Thanks. |
steveniemitz
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Oct 18, 2021
… temporary tables that don't exist. (apache#15635) * [BEAM-12482] Ensure that we ignore schema update options when loading temporary tables that don't exist. * fixup! Add comment.
steveniemitz
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Nov 1, 2021
… temporary tables that don't exist. (apache#15635) * [BEAM-12482] Ensure that we ignore schema update options when loading temporary tables that don't exist. * fixup! Add comment.
dmitriikuzinepam
pushed a commit
to dmitriikuzinepam/beam
that referenced
this pull request
Nov 2, 2021
… temporary tables that don't exist. (apache#15635) * [BEAM-12482] Ensure that we ignore schema update options when loading temporary tables that don't exist. * fixup! Add comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't solve schema update completely and only works if the destination table doesn't exist but expands slightly the set of use cases supported.
This depends on the destination table having a schema that matches that of the temp tables effectively making the
SchemaUpdateOptions moot.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.