Skip to content

[BEAM-12482] Ensure that we ignore schema update options when loading temporary tables that don't exist. #15635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukecwik merged 2 commits into from
Oct 6, 2021
Merged

[BEAM-12482] Ensure that we ignore schema update options when loading temporary tables that don't exist. #15635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e31c5a
[BEAM-12482] Ensure that we ignore schema update options when loading…
lukecwik Oct 1, 2021
3d9d002
fixup! Add comment.
lukecwik Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...o/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,9 @@ private PCollection<KV<TableDestination, WriteTables.Result>> writeTempTables(
kmsKey,
rowWriterFactory.getSourceFormat(),
useAvroLogicalTypes,
schemaUpdateOptions))
// Note that we can't pass through the schema update options when creating temporary
// tables. They also shouldn't be needed. See BEAM-12482 for additional details.
Collections.emptySet()))
.setCoder(KvCoder.of(tableDestinationCoder, WriteTables.ResultCoder.INSTANCE));
}

Expand Down