[BEAM-115] Remove extraneous type parameter from Trigger, etc #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @bjchambers |
Contributor
|
Looks fine. There may be more narrowing of scope we can do but it can wait. It would be good to be able to write a trigger which depended on the window and was checked at application time. Unfortunately, since we don't carry LGTM |
Member
Author
|
Thanks for the review! |
4 tasks
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-hadoop] remove sneakythrows
damccorm
added a commit
that referenced
this pull request
Dec 9, 2022
…lf-hosted runners (#23135) * Updating build_playground_frontend Workflow(#168) Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added master changes in build_playground_frontend to avoid merge conflicts * Switching trigger to pull_request (#260) * Switching to pull_request * Removing ref from checkout Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com> Co-authored-by: Danny McCormick <dannymccormick@google.com>
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Dec 22, 2022
…lf-hosted runners (apache#23135) * Updating build_playground_frontend Workflow(apache#168) Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added master changes in build_playground_frontend to avoid merge conflicts * Switching trigger to pull_request (apache#260) * Switching to pull_request * Removing ref from checkout Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com> Co-authored-by: Danny McCormick <dannymccormick@google.com>
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no user-visible effect unless they have to declare a variable of type
Trigger, etc, since we use factory methods where extra type parameters are just a warning. For this PR, I have deliberately not cleared out such parameters from examples or integration tests, to be sure that nothing is broken. I will follow up with that.This is in service of the runner API in that triggers move towards a cross-language cross-runner syntax and clearing out this type parameter makes it easier to proceed with further refactors.