Skip to content

Conversation

@tgroh
Copy link
Member

@tgroh tgroh commented Apr 28, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Return as the output to InProcessEvaluationContext#handleResult(). This
allows a richer return type to improve possible behaviors when a result
is returned.

@tgroh
Copy link
Member Author

tgroh commented Apr 28, 2016

Replaces #249

@kennknowles
Copy link
Member

Seems obviously correct. While today this PR is a noop I understand this is a struct into which you will put things like elements that are blocked on side inputs, etc.

LGTM.

@tgroh tgroh force-pushed the ippr_committed_result_as_handle_result branch 2 times, most recently from ee4f9bb to 141b72d Compare April 28, 2016 20:13
Return as the output to InProcessEvaluationContext#handleResult(). This
allows a richer return type to improve possible behaviors when a result
is returned.
@tgroh tgroh force-pushed the ippr_committed_result_as_handle_result branch from 141b72d to 2618aa6 Compare April 28, 2016 20:18
@asfgit asfgit merged commit 2618aa6 into apache:master Apr 29, 2016
asfgit pushed a commit that referenced this pull request Apr 29, 2016
tgroh pushed a commit to tgroh/beam that referenced this pull request Apr 29, 2016
@davorbonaci
Copy link
Member

Looks like this PR broke the build:
https://builds.apache.org/job/beam_PostCommit_MavenVerify/303/console

(It seems it has raced with @swegner's merge.)

Can we get this forward-fixed?

iemejia pushed a commit to iemejia/beam that referenced this pull request Jan 12, 2018
mareksimunek added a commit to mareksimunek/beam that referenced this pull request May 9, 2018
mareksimunek added a commit to mareksimunek/beam that referenced this pull request May 9, 2018
mareksimunek added a commit to mareksimunek/beam that referenced this pull request May 9, 2018
mareksimunek added a commit to mareksimunek/beam that referenced this pull request May 9, 2018
…ashJoin

[euphoria-flink] apache#260 Flink - broadcast hash join
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
mareksimunek added a commit to seznam/beam that referenced this pull request Jul 9, 2018
mareksimunek added a commit to seznam/beam that referenced this pull request Jul 9, 2018
mareksimunek added a commit to seznam/beam that referenced this pull request Jul 9, 2018
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
damccorm added a commit that referenced this pull request Dec 9, 2022
…lf-hosted runners (#23135)

* Updating build_playground_frontend Workflow(#168)

Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>

* Added master changes in build_playground_frontend to avoid merge conflicts

* Switching trigger to pull_request (#260)

* Switching to pull_request

* Removing ref from checkout

Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com>
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
…lf-hosted runners (apache#23135)

* Updating build_playground_frontend Workflow(apache#168)

Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>

* Added master changes in build_playground_frontend to avoid merge conflicts

* Switching trigger to pull_request (apache#260)

* Switching to pull_request

* Removing ref from checkout

Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com>
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants