[BEAM-22] Correct sequence of pending element updates in InMemoryWatermarkManager #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @bjchambers |
Contributor
|
The description is a bit unclear -- please update. Also, this should probably have a test to verify proper behavior. |
tgroh
force-pushed
the
ippr_wm_pending_sequence
branch
from
1340e82 to
722331f
Compare
Member
Author
|
Fixed description, added comment. The test is pretty complex, and I'm going to replace the update implementation with one that has a dedicated thread, and only on #extractFiredTimers; which will cause the test to no longer be particularly relevant. |
tgroh
force-pushed
the
ippr_wm_pending_sequence
branch
2 times, most recently
from
97c0525 to
b6d993a
Compare
Because the WatermarkManager is not synchronized within the call to updatePending, the sequence in which pending queues are updated must be in such a manner as to add additional restrictions, then remove any restrictions which no longer apply. This ensures any intermediate read will see at worst a more restricted watermark than the actual watermark.
tgroh
force-pushed
the
ippr_wm_pending_sequence
branch
from
b6d993a to
76d3288
Compare
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
added a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…ashJoin [euphoria-flink] apache#260 Flink - broadcast hash join
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Adding additional pending elements/timers (and thus holds) always comes
before removing existing holds, so the watermark is never observed under
more stringent restrictions than currently exist.