-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-13806] Adding test suite for Go x-lang tests on Dataflow. #16819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Seed Job |
|
Run XVR_GoUsingJava_Dataflow PostCommit |
|
Run Seed Job |
|
Run XVR_GoUsingJava_Dataflow PostCommit |
|
@youngoli - Is this ready for a review? |
|
@youngoli - could you add reviewers? |
|
Sorry I haven't been checking this. I want to review it after I get confirmation that this works with Jenkins. Last time I tried Jenkins was completely down and even now it's still being a bit difficult (last I saw SeedJob was failing, and I'm trying now and the site isn't loading). |
|
Run Java PreCommit |
|
Run Seed Job |
|
Run XVR_GoUsingJava_Dataflow PostCommit |
2 similar comments
|
Run XVR_GoUsingJava_Dataflow PostCommit |
|
Run XVR_GoUsingJava_Dataflow PostCommit |
|
Run Seed Job |
|
Run XVR_GoUsingJava_Dataflow PostCommit |
Following the pattern of the other Dataflow X-Lang test suites, this one adds Go using Java expansion services. This needs to be tested on Jenkins.
|
Run Seed Job |
|
Run XVR_GoUsingJava_Dataflow PostCommit |
|
R: @lostluck This is the run I actually got to work: https://ci-beam.apache.org/job/beam_PostCommit_XVR_GoUsingJava_Dataflow_PR/5/ The errors look like legit errors as far as I can tell, although I haven't exactly been able to diagnose what's happening. Personally I'm in favor of just merging this as-is, and then triaging and creating Jiras like we usually do when one of our test suites starts failing. |
|
R: @ihji |
|
@ihji - could you please take a look at this change? |
ihji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
|
Just to clarify why I think this should be submitted despite the test being red (since I've been getting some confusion about it offline): From what I investigated, the test framework and Jenkins configuration itself, which is what this PR is changing, seems to be working just fine. It runs the test suite no problem, the failure doesn't seem to be due to the test environment, and all the tests except one are passing. This indicates to me that the redness is due to an actual failure that was already happening but unnoticed because it wasn't being tested. The next steps once this is merged is to immediately create a Jira for this failure and start triaging and fixing it, like we do when existing test suites turn red. |
|
this is perma-red https://ci-beam.apache.org/job/beam_PostCommit_XVR_GoUsingJava_Dataflow/, also could we move this suite off the java runner harness, perhaps use ULR instead? |
|
All Go SDK jobs on Dataflow should be using UW, and not the Java Runner
Harness.
By ULR, do you mean the Python Portable Runner? Wouldn't that be a
different suite?
…On Thu, Apr 28, 2022, 5:35 PM Yichi Zhang ***@***.***> wrote:
this is perma-red
https://ci-beam.apache.org/job/beam_PostCommit_XVR_GoUsingJava_Dataflow/,
also could we move this suite off the java runner harness, perhaps use ULR
instead?
—
Reply to this email directly, view it on GitHub
<#16819 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDOFLQSW66IOJCGCIZSHTVHMVDXANCNFSM5OC6UMVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
if this is using UW I see no reason for it to depend on ":runners:google-cloud-dataflow-java:worker:shadowJar", perhaps I misunderstood something. |
Following the pattern of the other Dataflow X-Lang test suites, this one adds Go using Java expansion services. This needs to be tested on Jenkins.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.