Skip to content

Conversation

@youngoli
Copy link
Contributor

Following the pattern of the other Dataflow X-Lang test suites, this one adds Go using Java expansion services. This needs to be tested on Jenkins.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@youngoli
Copy link
Contributor Author

Run Seed Job

@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

@youngoli
Copy link
Contributor Author

Run Seed Job

@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

@aaltay
Copy link
Member

aaltay commented Feb 25, 2022

@youngoli - Is this ready for a review?

@aaltay
Copy link
Member

aaltay commented Mar 10, 2022

@youngoli - could you add reviewers?

@youngoli
Copy link
Contributor Author

Sorry I haven't been checking this. I want to review it after I get confirmation that this works with Jenkins. Last time I tried Jenkins was completely down and even now it's still being a bit difficult (last I saw SeedJob was failing, and I'm trying now and the site isn't loading).

@aaltay
Copy link
Member

aaltay commented Mar 11, 2022

Run Java PreCommit

@youngoli
Copy link
Contributor Author

Run Seed Job

@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

2 similar comments
@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

@youngoli
Copy link
Contributor Author

Run Seed Job

@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

Following the pattern of the other Dataflow X-Lang test suites, this one adds Go using Java expansion services. This needs to be tested on Jenkins.
@youngoli
Copy link
Contributor Author

Run Seed Job

@youngoli
Copy link
Contributor Author

Run XVR_GoUsingJava_Dataflow PostCommit

@youngoli
Copy link
Contributor Author

R: @lostluck

This is the run I actually got to work: https://ci-beam.apache.org/job/beam_PostCommit_XVR_GoUsingJava_Dataflow_PR/5/

The errors look like legit errors as far as I can tell, although I haven't exactly been able to diagnose what's happening. Personally I'm in favor of just merging this as-is, and then triaging and creating Jiras like we usually do when one of our test suites starts failing.

@youngoli
Copy link
Contributor Author

R: @ihji
Since you've been the main dev working on the Dataflow xlang tests.

@aaltay aaltay requested a review from ihji March 23, 2022 03:29
@aaltay
Copy link
Member

aaltay commented Mar 25, 2022

@ihji - could you please take a look at this change?

Copy link
Contributor

@ihji ihji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@youngoli
Copy link
Contributor Author

Just to clarify why I think this should be submitted despite the test being red (since I've been getting some confusion about it offline):

From what I investigated, the test framework and Jenkins configuration itself, which is what this PR is changing, seems to be working just fine. It runs the test suite no problem, the failure doesn't seem to be due to the test environment, and all the tests except one are passing.

This indicates to me that the redness is due to an actual failure that was already happening but unnoticed because it wasn't being tested. The next steps once this is merged is to immediately create a Jira for this failure and start triaging and fixing it, like we do when existing test suites turn red.

@y1chi
Copy link
Contributor

y1chi commented Apr 29, 2022

this is perma-red https://ci-beam.apache.org/job/beam_PostCommit_XVR_GoUsingJava_Dataflow/, also could we move this suite off the java runner harness, perhaps use ULR instead?

@lostluck
Copy link
Contributor

lostluck commented Apr 29, 2022 via email

@y1chi
Copy link
Contributor

y1chi commented Apr 29, 2022

All Go SDK jobs on Dataflow should be using UW, and not the Java Runner Harness. By ULR, do you mean the Python Portable Runner? Wouldn't that be a different suite?

On Thu, Apr 28, 2022, 5:35 PM Yichi Zhang @.> wrote: this is perma-red https://ci-beam.apache.org/job/beam_PostCommit_XVR_GoUsingJava_Dataflow/, also could we move this suite off the java runner harness, perhaps use ULR instead? — Reply to this email directly, view it on GitHub <#16819 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKDOFLQSW66IOJCGCIZSHTVHMVDXANCNFSM5OC6UMVQ . You are receiving this because you were mentioned.Message ID: @.>

if this is using UW I see no reason for it to depend on ":runners:google-cloud-dataflow-java:worker:shadowJar", perhaps I misunderstood something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants