[BEAM-13857] Switched Go IT script to using Go flags for expansion services #17161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvices This is a followup to a previous PR (apache#16908) which added the feature but didn't switch existing tests to using it. This switches existing tests to using the feature (along with making sure it's set up properly in a way that works).
Contributor
Author
Contributor
Author
|
I'd like to note for future reference that the cross-language postcommits for Python Direct, Flink, and Spark all seem to currently be failing, so while running them I'm not going to be checking that they succeed, but that the failures don't change, and we can be reasonably sure that this PR didn't change anything. Since this only affects the way expansion services are initialized for Go, any errors should probably be visible over existing errors. |
Contributor
Author
|
Run XVR_Direct PostCommit |
Contributor
Author
|
Run XVR_Flink PostCommit |
Contributor
Author
|
Run XVR_Spark PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #17161 +/- ##
==========================================
- Coverage 73.96% 73.95% -0.01%
==========================================
Files 671 671
Lines 88245 88245
==========================================
- Hits 65270 65264 -6
- Misses 21863 21869 +6
Partials 1112 1112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
Flink failed with this, rerunning. |
Contributor
|
Run XVR_Flink PostCommit |
lostluck
approved these changes
Mar 29, 2022
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
Assuming the flink failure is a flake of some kind, this LGTM. Thanks! I wish we had a better/cleaner mechanism to put a prefix like that for testing, but I can't think of anything preferable to the current no-magic approach.
Contributor
|
Run Flink CrossLanguageValidatesRunner Tests |
Contributor
|
Run XVR_Flink PostCommit |
Contributor
Author
|
I'm inclined to think this is a flake for the Flink XVR tests, since this change shouldn't be doing anything to the specific of Flink connections. And looking at the Non-PR version, looks like it's failing with the same error (ex. https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/5215/) Java Precommit I already know is being flaky due to timeouts and this change isn't modifying Java at all. CommunityMetrics Precommit similarly is currently not working for unrelated reasons. |
Contributor
Author
|
That said, before I merge this I'm going to double check it doesn't conflict with #16819 |
Contributor
|
Run Flink CrossLanguageValidatesRunner Tests |
Contributor
|
Run XVR_Flink PostCommit |
Contributor
|
Run CommunityMetrics PreCommit |
Contributor
|
Seems like a flake. |
Contributor
|
Run XVR_Flink PostCommit |
Contributor
|
Up, just an unrelated flake. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to a previous PR (#16908) which added the feature but didn't switch existing tests to using it. This switches existing tests to using the feature (along with making sure it's set up properly in a way that works).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.