Skip to content

[BEAM-12753] and [BEAM-12815] Fix Flink Integration Tests #17067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostluck merged 2 commits into from
Mar 18, 2022
Merged

[BEAM-12753] and [BEAM-12815] Fix Flink Integration Tests #17067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986dcac
Turn some flink integration tests back on
damccorm Mar 10, 2022
1769be9
Fix go integration tests on flink
damccorm Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sdks/go/test/integration/integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,7 @@ var portableFilters = []string{
var flinkFilters = []string{
// TODO(BEAM-11500): Flink tests timing out on reads.
"TestXLang_Combine.*",
// TODO(BEAM-12815): Test fails: "Insufficient number of network buffers".
"TestXLang_Multi",
"TestDebeziumIO_BasicRead",
// TODO(BEAM-12753): Flink test stream fails for non-string/byte slice inputs
"TestTestStream.*Sequence.*",
// Triggers are not yet supported
"TestTrigger.*",
Copy link
Contributor

@lostluck lostluck Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try (in separate PRs) removing the other test filters as well, as I can see all of these being tightly related (timeouts and memory for debezium, and Triggers leaning on TestStream).

}
Expand Down
20 changes: 20 additions & 0 deletions sdks/go/test/resources/flink-conf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#

taskmanager.memory.network.fraction: 0.2
taskmanager.memory.network.max: 2gb
4 changes: 4 additions & 0 deletions sdks/go/test/run_validatesrunner_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ set -e
trap '! [[ "$BASH_COMMAND" =~ ^(echo|read|if|ARGS|shift|SOCKET_SCRIPT|\[\[) ]] && \
cmd=`eval echo "$BASH_COMMAND" 2>/dev/null` && echo "\$ $cmd"' DEBUG

# Resolve current directory
CURRENT_DIRECTORY=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

# Default test targets.
TESTS="./test/integration/... ./test/regression"

Expand Down Expand Up @@ -271,6 +274,7 @@ elif [[ "$RUNNER" == "flink" || "$RUNNER" == "spark" || "$RUNNER" == "samza" ||
java \
-jar $FLINK_JOB_SERVER_JAR \
--flink-master [local] \
--flink-conf-dir $CURRENT_DIRECTORY/resources \
--job-port $JOB_PORT \
--expansion-port 0 \
--artifact-port 0 &
Expand Down