-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-12753] and [BEAM-12815] Fix Flink Integration Tests #17067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Go Flink ValidatesRunner |
Codecov Report
@@ Coverage Diff @@
## master #17067 +/- ##
==========================================
- Coverage 73.94% 73.94% -0.01%
==========================================
Files 667 667
Lines 88056 88056
==========================================
- Hits 65116 65112 -4
- Misses 21829 21833 +4
Partials 1111 1111
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2f767c7 to
e0d716c
Compare
e0d716c to
1769be9
Compare
|
Run Go Flink ValidatesRunner |
jrmccluskey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is a big win for helping us get testing for streaming features up and running
|
R: @youngoli for final approval |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @youngoli for label go. Available commands:
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
lostluck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
FYI @ibzib since you could find the Flink config adjustment useful someday.
| // TODO(BEAM-12753): Flink test stream fails for non-string/byte slice inputs | ||
| "TestTestStream.*Sequence.*", | ||
| // Triggers are not yet supported | ||
| "TestTrigger.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try (in separate PRs) removing the other test filters as well, as I can see all of these being tightly related (timeouts and memory for debezium, and Triggers leaning on TestStream).
Right now, multiple go integration tests are excluded on Flink because they run into the following Flink error:
(the number of available/required network buffers is variable from run to run).
The underlying cause of this error is that we allow a greater parallelism than we have network memory to support for these tests (specifically, parallelism = # available cores[1]), and we run into issues when performing shuffle operations. This is expected to happen sometimes[1] depending on the workload, with the expectation that users will do the appropriate tuning. This PR fixes this problem by doubling the fraction of flink memory to be used as network memory from 10% to 20% and upping the max network memory for task executors from 1 gb to 2 gb (see more on these config options here - https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/#taskmanager-memory-network-fraction). This will help us avoid this issue while still staying within the bounds of a reasonable flink config.
[1] https://lists.apache.org/thread/p04qpcxxfvpqzowgy7lpos1gzdns4cnm
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.