-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-12815] Try to fix flaky Flink Post Commit #17227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12815] Try to fix flaky Flink Post Commit #17227
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Run XVR_Flink PostCommit |
|
Run XVR_Flink PostCommit |
|
Run Go Flink ValidatesRunner |
|
Run Go Flink ValidatesRunner |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
lostluck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Ping me if a revert is needed. Thanks!
|
Run XVR_Flink PostCommit |
Right now, Go flink Post commits are failing with
java.io.IOException: Insufficient number of network buffers: required 17, but only 16 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'.This is the same underlying issue I fixed in #17067 but it shows up again here because we have a different mechanism for spinning up flink for these post commit tests. This PR does 2 things:
beam/runners/flink/job-server/flink_job_server.gradle
Line 116 in 5a62228
NOTE: The post commit changes (changing PflinkConfDir) aren't able to be tested because I can't actually repro the problem locally, and Jenkin's infra seems to run post commits against master (even when triggered against PRs). So this may not work, but the blast radius (potential to briefly break post-commits) is relatively small, and I'll quickly revert it if this makes things any worse. I do feel pretty confident it won't make things worse though since I was able to at least run the tests locally with
-PflinkConfDir=$pwd/runners/flink/src/test/resources.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.