Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Mar 31, 2022

Right now, Go flink Post commits are failing with java.io.IOException: Insufficient number of network buffers: required 17, but only 16 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'.

This is the same underlying issue I fixed in #17067 but it shows up again here because we have a different mechanism for spinning up flink for these post commit tests. This PR does 2 things:

  1. It moves the memory buffer config used by the Go tests into our shared flink test config. This is verified working in the precommit checks.
  2. It sets PflinkConfDir to point to this config directory in our post commit infra. This corresponds to a property in our flink gradle job server file where we start up flink -
    if (project.hasProperty('flinkConfDir'))

NOTE: The post commit changes (changing PflinkConfDir) aren't able to be tested because I can't actually repro the problem locally, and Jenkin's infra seems to run post commits against master (even when triggered against PRs). So this may not work, but the blast radius (potential to briefly break post-commits) is relatively small, and I'll quickly revert it if this makes things any worse. I do feel pretty confident it won't make things worse though since I was able to at least run the tests locally with -PflinkConfDir=$pwd/runners/flink/src/test/resources.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Mar 31, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Mar 31, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Mar 31, 2022

Can one of the admins verify this patch?

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@damccorm
Copy link
Contributor Author

Run Go Flink ValidatesRunner

@damccorm damccorm changed the title WIP: Fix flaky Flink Post Commit Try to fix flaky Flink Post Commit Mar 31, 2022
@damccorm damccorm marked this pull request as ready for review March 31, 2022 16:17
@damccorm damccorm changed the title Try to fix flaky Flink Post Commit [BEAM-12815] Try to fix flaky Flink Post Commit Mar 31, 2022
@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damccorm
Copy link
Contributor Author

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Ping me if a revert is needed. Thanks!

@lostluck lostluck merged commit ef8887e into apache:master Mar 31, 2022
@damccorm damccorm deleted the users/damccorm/flink-flaky-tests branch March 31, 2022 16:53
@damccorm
Copy link
Contributor Author

Run XVR_Flink PostCommit

@damccorm damccorm mentioned this pull request Apr 4, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants