Skip to content

Conversation

@aaltay
Copy link
Member

@aaltay aaltay commented Mar 24, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@aaltay aaltay changed the title [WIP] Update tox.ini for pydocs [BEAM-14172] Update tox.ini for pydocs Mar 24, 2022
@aaltay aaltay requested a review from ibzib March 24, 2022 22:00
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I tried updating sphinx at some point because I thought it would be easy and it turned out it was non-trivial for some reason (not super helpful I know..)

Co-authored-by: Brian Hulette <bhulette@google.com>
@aaltay
Copy link
Member Author

aaltay commented Mar 24, 2022

I think I tried updating sphinx at some point because I thought it would be easy and it turned out it was non-trivial for some reason (not super helpful I know..)

I looked at the version gap and did not attempt to upgrade. I think we need to re-purpose the bug to update sphinx.

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #17176 (2d35d86) into master (993061a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17176   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files         672      672           
  Lines       88259    88262    +3     
=======================================
+ Hits        65277    65283    +6     
+ Misses      21869    21866    -3     
  Partials     1113     1113           
Flag Coverage Δ
python 83.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/typehints/decorators.py 92.73% <0.00%> (+0.06%) ⬆️
...runners/interactive/display/pcoll_visualization.py 86.36% <0.00%> (+0.50%) ⬆️
...pache_beam/runners/interactive/interactive_beam.py 81.39% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993061a...2d35d86. Read the comment docs.

@aaltay aaltay merged commit 0c93be1 into master Mar 25, 2022
@aaltay aaltay deleted the aaltay-patch-1 branch March 25, 2022 00:21
@TheNeuralBit
Copy link
Member

@youngoli you may need this on the release branch

youngoli pushed a commit to youngoli/beam that referenced this pull request Apr 11, 2022
youngoli added a commit that referenced this pull request Apr 11, 2022
…Update tox.ini for pydocs (#17176)

[cherry-pick][release-2.38.0][BEAM-14172] Update tox.ini for pydocs (#17176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants