Skip to content

Conversation

@youngoli
Copy link
Contributor

@youngoli youngoli commented Apr 11, 2022

(cherry picked from commit 0c93be1)

Missed this cherry-pick earlier and I need it for RC creation, so I might merge this in before it gets approved and hope for a retroactive approval, just in order to unblock myself. It's a very small change anyway.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@youngoli
Copy link
Contributor Author

R: @TheNeuralBit @aaltay

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #17332 (9cc9692) into release-2.38.0 (93ac2a0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release-2.38.0   #17332      +/-   ##
==================================================
- Coverage           73.96%   73.96%   -0.01%     
==================================================
  Files                 672      672              
  Lines               88259    88270      +11     
==================================================
+ Hits                65279    65287       +8     
- Misses              21867    21870       +3     
  Partials             1113     1113              
Flag Coverage Δ
python 83.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che_beam/runners/interactive/interactive_runner.py 92.85% <0.00%> (-0.72%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.26% <0.00%> (-0.25%) ⬇️
.../apache_beam/options/pipeline_options_validator.py 98.90% <0.00%> (+0.03%) ⬆️
...dks/python/apache_beam/options/pipeline_options.py 94.91% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ac2a0...9cc9692. Read the comment docs.

@youngoli
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@youngoli
Copy link
Contributor Author

Again, merging this without approval to unblock, will need to get some retroactive approval.

@youngoli youngoli merged commit 3da922c into apache:release-2.38.0 Apr 11, 2022
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants