Skip to content

Conversation

@kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace "<Jira issue #>" in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@kennknowles
Copy link
Member Author

R: @bjchambers

@bjchambers
Copy link
Contributor

LGTM

@asfgit asfgit merged commit 1c448bd into apache:master Apr 13, 2016
asfgit pushed a commit that referenced this pull request Apr 13, 2016
@kennknowles kennknowles deleted the getFinishedMergingWindows branch April 19, 2016 17:22
swegner pushed a commit to swegner/beam that referenced this pull request Apr 22, 2016
Validate that Pubsub resource names are at least 3 chars
iemejia pushed a commit to iemejia/beam that referenced this pull request Jan 12, 2018
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
 [euphoria-operator-testkit] activate mistakenly ignored test
damccorm added a commit that referenced this pull request Dec 9, 2022
…rs (#23160)

* Updated java_tests workflow (#172)

Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>

* Added master changes in java_tests to avoid merge conflicts

* Set runDataflow input to non-required

Co-authored-by: Danny McCormick <dannymccormick@google.com>

* Switching trigger to pull_request (#263)

* Switching trigger to pull_request

* Removing ref from checkout

Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com>
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
…rs (apache#23160)

* Updated java_tests workflow (apache#172)

Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>

* Added master changes in java_tests to avoid merge conflicts

* Set runDataflow input to non-required

Co-authored-by: Danny McCormick <dannymccormick@google.com>

* Switching trigger to pull_request (apache#263)

* Switching trigger to pull_request

* Removing ref from checkout

Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com>
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants