Skip to content

Remove unused MergingTriggerContext#getFinishedMergingWindows method #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 1 commit into from
Apr 13, 2016
Merged

Remove unused MergingTriggerContext#getFinishedMergingWindows method #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/windowing/Trigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ public interface MergingTriggerInfo extends TriggerInfo {

/** Return true if the trigger is finished in all windows being merged. */
public abstract boolean finishedInAllMergingWindows();

/** Return the merging windows in which the trigger is finished. */
public abstract Iterable<? extends BoundedWindow> getFinishedMergingWindows();
}

/**
Expand Down
11 changes: 0 additions & 11 deletions sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/util/TriggerContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import com.google.common.collect.FluentIterable;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Iterables;
import com.google.common.collect.Maps;

import org.joda.time.Instant;

Expand Down Expand Up @@ -249,16 +248,6 @@ public boolean finishedInAllMergingWindows() {
}
return true;
}

@Override
public Iterable<? extends BoundedWindow> getFinishedMergingWindows() {
return Maps.filterValues(finishedSets, new Predicate<FinishedTriggers>() {
@Override
public boolean apply(FinishedTriggers finishedSet) {
return finishedSet.isFinished(trigger);
}
}).keySet();
}
}

private class StateAccessorImpl implements StateAccessor<Object> {
Expand Down