Skip to content

Update 'examples' archetype #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 2 commits into from
Apr 13, 2016
Merged

Update 'examples' archetype #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2978a9
Update 'examples' archetype
davorbonaci Apr 13, 2016
8afd348
Update 'starter' archetype
davorbonaci Apr 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sdks/java/maven-archetypes/examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,21 @@
<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>2.4</version>
<executions>
<!-- archetype-packaging above binds this plugin's goals as follows:
archetype:jar to the package phase,
archetype:integration-test to the integration-test phase,
archetype:update-local-catalog to the install phase.
We defer the integration-test goal to the install phase, since
this test actually depends on the core SDK to be installed. -->
Copy link
Member

@lukecwik lukecwik Apr 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment that this is the case until the sdk has an actual artifact that is released which the archetype can then depend on.

Copy link
Member Author

@davorbonaci davorbonaci Apr 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not quite. Ideally, the build should be always be using an artifact produced by this build. Say, we could have introduced backward-incompatible changes that would break this again even if a matching artifact is released previously.

Copy link
Member

@lukecwik lukecwik Apr 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, without the user installing the artifacts, I don't know how to get the archetypes to use an output of the build otherwise this would be a non-issue.

<execution>
<id>default-integration-test</id>
<phase>install</phase>
<goals>
<goal>integration-test</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
Expand Down
15 changes: 15 additions & 0 deletions sdks/java/maven-archetypes/starter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,21 @@
<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>2.4</version>
<executions>
<!-- archetype-packaging above binds this plugin's goals as follows:
archetype:jar to the package phase,
archetype:integration-test to the integration-test phase,
archetype:update-local-catalog to the install phase.
We defer the integration-test goal to the install phase, since
this test actually depends on the core SDK to be installed. -->
<execution>
<id>default-integration-test</id>
<phase>install</phase>
<goals>
<goal>integration-test</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
Expand Down