Update 'examples' archetype #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the test run in the 'install' phase, as opposed to the 'integration-test' phase.
| archetype:integration-test to the integration-test phase, | ||
| archetype:update-local-catalog to the install phase. | ||
| We defer the integration-test goal to the install phase, since | ||
| this test actually depends on the core SDK to be installed. --> |
Member
There was a problem hiding this comment.
I would add a comment that this is the case until the sdk has an actual artifact that is released which the archetype can then depend on.
Member
Author
There was a problem hiding this comment.
Well, not quite. Ideally, the build should be always be using an artifact produced by this build. Say, we could have introduced backward-incompatible changes that would break this again even if a matching artifact is released previously.
Member
There was a problem hiding this comment.
Unfortunately, without the user installing the artifacts, I don't know how to get the archetypes to use an output of the build otherwise this would be a non-issue.
This makes the test run in the 'install' phase, as opposed to the 'integration-test' phase.
Member
|
LGTM |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…tream-inputs add UnboundedSource and BoundedSource
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the test run in the 'install' phase, as opposed to the 'integration-test' phase.
R: @lukecwik