Add DirtyBit to represent whether Counters have been committed. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peihe
force-pushed
the
counter-dirty-bit
branch
from
4da51b9 to
99c76c1
Compare
Contributor
Author
|
R: @bjchambers |
| * committing() None COMMITTING None | ||
| * committed() None None COMMITTED | ||
| */ | ||
| @VisibleForTesting |
Member
There was a problem hiding this comment.
DirtyBit suggest a bool, which this is explicitly not. CommitState?
peihe
force-pushed
the
counter-dirty-bit
branch
from
3e5d21c to
9b76b75
Compare
peihe
force-pushed
the
counter-dirty-bit
branch
from
9b76b75 to
09f4097
Compare
Member
|
LGTM |
peihe
force-pushed
the
counter-dirty-bit
branch
from
604f5ab to
b7bd50c
Compare
| @Nullable | ||
| public abstract CounterMean<T> getMean(); | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
/**
* Represents ...
(No need to say CommitState)
peihe
force-pushed
the
counter-dirty-bit
branch
from
dee5843 to
8973646
Compare
Contributor
Author
|
PTAL |
| /** | ||
| * Returns if the counter contains non-committed aggregate. | ||
| * | ||
| * <p>After all possible mutations have completed, the reader should check |
Contributor
There was a problem hiding this comment.
This looks great. Can you put the details of this counter lifecycle/contract in the Counter class javadoc?
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
Hadoop tuning
2 tasks
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Update `pbs_for_create`, `pbs_for_set_no_merge`, `pbs_for_set_with_merge`, and `pbs_for_update` to match semantics expected by current versions of [conformance tests](googleapis/conformance-tests@0bb8520): - Rather than create separate `Write.transform` messages to hold field transforms, inline them as `update_transforms` in the main `Write.update` message (which will always be created now). Copy in the current version of the conftest JSON files and verify. Closes apache#217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.