Make hash function in Coder base class more conservative. #5429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Contributor
Author
|
R: @aaltay |
aaltay
reviewed
May 30, 2018
| def __eq__(self, other): | ||
| return (self.__class__ == other.__class__ | ||
| and self._dict_without_impl() == other._dict_without_impl()) | ||
| # pylint: enable=protected-access |
Contributor
Author
There was a problem hiding this comment.
It's a matching comment for the comment in line 219. I think the comment in #219 is still needed.
Member
There was a problem hiding this comment.
Got it. L219 was not visible by default.
aaltay
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BEAM-3724]
Make hash function in Coder base class more conservative, to avoid evaluating hash based on potentially mutable collection.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.