Skip to content

Conversation

@dannymartinm
Copy link
Contributor

@dannymartinm dannymartinm commented Aug 11, 2022

DO NOT MERGE

As part of the issue 21106, @elink21 and I have implemented the self-hosted runners for the Ubuntu and Windows operating systems.

In this PR you will find the following changes:

  • Updates in workflows to runs-on self-hosted runners (Ubuntu and Windows)
  • Docker and Kubernetes files to reproduce the environment of the Ubuntu runners in local and in Google Kubernetes Engine
  • Scripts for the Windows runners implementation on GCP Compute Engine (VMs)
  • Cloud Function scripts
  • Detailed documentation in README files

Note: We will rely on GitHub-hosted runners for MacOS builds until a straightforward implementation approach comes out.

PR#16511 : Previous PR for reference.
BEAM-12812: Original Jira may contain additional context.

Migration Release Plan
Once this PR is approved, we are planning to create one PR per workflow and merge one by one in case some rollback is needed.

Thank you very much!


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@benEng benEng mentioned this pull request Sep 28, 2022
4 tasks
@elink21
Copy link
Contributor

elink21 commented Nov 9, 2022

Status update: reviewed by @damccorm, waiting for the migration window to deploy the infrastructure and request the merge.

@damccorm
Copy link
Contributor

@dannymartinm @elink21 what should we do with this PR at this point? The docs are probably still helpful to have, but the workflow changes have been pushed out into separate PRs

@elink21
Copy link
Contributor

elink21 commented Dec 12, 2022

@dannymartinm @elink21 what should we do with this PR at this point? The docs are probably still helpful to have, but the workflow changes have been pushed out into separate PRs

Fortunately documentation was also divided into individual PRs, however due to the latest changes I will work on updating the infrastructure specs and it's documentation, if I'm not wrong this PR with all the changes was created as a reference for a quicker review, but everything was included in the other ones. For me it looks like we can close this one, what do you think @dannymartinm ?

@dannymartinm
Copy link
Contributor Author

@dannymartinm @elink21 what should we do with this PR at this point? The docs are probably still helpful to have, but the workflow changes have been pushed out into separate PRs

Fortunately documentation was also divided into individual PRs, however due to the latest changes I will work on updating the infrastructure specs and it's documentation, if I'm not wrong this PR with all the changes was created as a reference for a quicker review, but everything was included in the other ones. For me it looks like we can close this one, what do you think @dannymartinm ?

Hi @elink21 and @damccorm , yes this PR was a previous step for the release and merging process just to have the full picture of our changes. We have split this PR into small ones (some of them already merged).

We can close this PR. Thank you team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants