-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Go SDK Katas: Update beam module dependency #22753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go SDK Katas: Update beam module dependency #22753
Conversation
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
|
||
| // Katas files | ||
| "learning/katas/**/course-info.yaml", | ||
| "learning/katas/**/task-info.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IntelliJ edu course creation tool updates these files and removes the license. Whenever one updates anything in the course files, they would have to manually update the license information. These files only store metadata about the course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense! Lets not fight IntelliJ here, it's not a good use of anyone's time.
I noticed this didn't happen in #22753
I noticed this didn't happen in #22753
lostluck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for the update! Fixing the imports to reflect the production usage is most excellent.
The SDK has triggers now, and in 2.42.0 it looks like we'll have State, if not timers, so the course can expand! But we most certainly want to wait for a slightly easier to use, portable Go runner before having a stand alone kata course demo those features.
|
@lostluck Thank you so much for reviewing this! We are in the process of building Tour of Beam. So perhaps we can add course content there. |
I noticed this didn't happen in apache#22753
This PR fixes #22751 by updating the Beam SDK learning katas module dependency.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.UpdateCHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.