Skip to content

[GitHub Actions] - Updates in Build Playground Backend to runs-on Self-hosted runners #23134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damccorm merged 5 commits into from
Dec 9, 2022
Merged

[GitHub Actions] - Updates in Build Playground Backend to runs-on Self-hosted runners #23134

damccorm merged 5 commits into from
Dec 9, 2022

Conversation

@dannymartinm
Copy link
Contributor

@dannymartinm dannymartinm commented Sep 9, 2022

DO NOT MERGE until the infrastructure is in place. Please talk to @dannymartinm @elink21 before merging

As part of the issue 21106, @elink21 and I have implemented the self-hosted runners for the Ubuntu and Windows operating systems.

Please see the Approved Pull Request (PR#22703) for reference.

In this PR you will find the following changes:

  • Updates in workflow Build Playground Backend to runs-on self-hosted runners
    • Ubuntu

PR#16511 : Previous PR for reference.
BEAM-12812: Original Jira may contain additional context.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damccorm
damccorm approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please comment here when it is ready to merge.

I think it is a good idea for us to first only merge one of these workflows so that we can validate everything is working before switching everything over

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 9, 2022
@elink21
Copy link
Contributor

elink21 commented Nov 9, 2022

Status update: reviewed by @damccorm, waiting for the migration window to deploy the infrastructure and request the merge.

@github-actions github-actions bot removed the stale label Nov 10, 2022
@elink22
Switching trigger to pull_request (#259)
8a0bac1 
* Switching to pull_request

* Removing ref from checkout
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Reminder, please take a look at this pr: @damccorm

@damccorm damccorm merged commit 9689995 into apache:master Dec 9, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
@dannymartinm @elink21
@elink22 @damccorm @lostluck
[GitHub Actions] - Updates in Build Playground Backend to runs-on Sel…
7f46821 
…f-hosted runners (apache#23134)

* Updating build_playground_backend workflow (apache#167)

Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>

* Added master changes in build_playground_backend to avoid merge conflicts

* Reverted GO_VERSION and BEAM_VERSION to have the same as master

build_playground_backend

* Switching trigger to pull_request (apache#259)

* Switching to pull_request

* Removing ref from checkout

Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com>
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Co-authored-by: elink22 <103056145+elink22@users.noreply.github.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damccorm damccorm damccorm approved these changes

Assignees

No one assigned

Labels

build Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dannymartinm @elink21 @damccorm @elink22