[GitHub Actions] - INFRA scripts to implement GCP Self-hosted runners (Ubuntu&Windows) #23158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…22703 in order to create a new PR only with Infra related work.
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
damccorm
reviewed
Sep 13, 2022
| Windows Virtual machines have the following specifications | ||
|
|
||
| #### VM specifications | ||
| * Instance Template: _TODO: Add GCP link when final resources are in place._ |
Contributor
There was a problem hiding this comment.
Calling out this TODO since we should resolve before merging if possible, or create an issue if not
Contributor
There was a problem hiding this comment.
We have resolved the image nomenclature, it's going to be added, thanks!
Contributor
There was a problem hiding this comment.
We are adding the template name instead since a hardcoded link will become outdated quickly.
.github/gh-actions-self-hosted-runners/helper-functions/cloud-functions/generateToken/index.js
Outdated
Show resolved
Hide resolved
...h-actions-self-hosted-runners/helper-functions/cloud-functions/monitorRunnersStatus/index.js
Outdated
Show resolved
Hide resolved
...h-actions-self-hosted-runners/helper-functions/cloud-functions/monitorRunnersStatus/index.js
Outdated
Show resolved
Hide resolved
...h-actions-self-hosted-runners/helper-functions/cloud-functions/monitorRunnersStatus/index.js
Show resolved
Hide resolved
...h-actions-self-hosted-runners/helper-functions/cloud-functions/monitorRunnersStatus/index.js
Outdated
Show resolved
Hide resolved
.github/gh-actions-self-hosted-runners/self-hosted-linux/README.md
Outdated
Show resolved
Hide resolved
.github/gh-actions-self-hosted-runners/self-hosted-windows/shutdownScript.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
…stead of inner conditions. Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
* Implementing Review Changes * Refactoring to use find instead of plain loops and adding env var validation * Adding REQUIRED_ENV_VARS as a constant Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
damccorm
reviewed
Sep 14, 2022
...h-actions-self-hosted-runners/helper-functions/cloud-functions/monitorRunnersStatus/index.js
Outdated
Show resolved
Hide resolved
.github/gh-actions-self-hosted-runners/helper-functions/cloud-functions/generateToken/index.js
Outdated
Show resolved
Hide resolved
.github/gh-actions-self-hosted-runners/helper-functions/cloud-functions/generateToken/index.js
Outdated
Show resolved
Hide resolved
* Using octokit paginate Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
damccorm
approved these changes
Sep 15, 2022
Contributor
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Thanks for the changes, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the issue #21106, @elink21 and I have implemented the self-hosted runners for the Ubuntu and Windows operating systems.
Please see the Approved Pull Request (PR#22703) for reference.
In this PR you will find the following changes:
Note: We will rely on GitHub-hosted runners for MacOS builds until a straightforward implementation approach comes out.
PR#16511 : Previous PR for reference.
BEAM-12812: Original Jira may contain additional context.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.