Skip to content

[GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners #23162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dannymartinm wants to merge 3 commits into from
Closed

[GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners #23162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c933683
Updated playground_deploy_examples Workflow (#176)
elink21 Sep 9, 2022
86eeda5
Added master changes in playground_deploy_examples to avoid merge con…
dannymartinm Sep 9, 2022
066fed7
Switching trigger to pull_request (#265)
elink22 Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/playground_deploy_examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# limitations under the License.

name: Collect And Deploy Playground Examples

on:
pull_request:
types:
Expand All @@ -26,10 +25,11 @@ env:
BEAM_VERSION: 2.40.0
K8S_NAMESPACE: playground-backend
HELM_APP_NAME: playground-backend

jobs:
check_examples:
name: Check examples
runs-on: ubuntu-latest
runs-on: [self-hosted, ubuntu-20.04]
outputs:
example_has_changed: ${{ steps.check_has_example.outputs.example_has_changed }}
steps:
Expand All @@ -43,6 +43,14 @@ jobs:
- name: install deps
run: pip install -r requirements.txt
working-directory: playground/infrastructure
- name: Install PowerShell
Copy link
Contributor

@damccorm damccorm Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than installing powershell, can we just convert the pwsh block below to a more generic script block? It isn't doing anything that a bash shell shouldn't be able to do.

Copy link
Contributor Author

@dannymartinm dannymartinm Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we are adding the required installations to make the workflows work. In this case, we are afraid that by changing this block of code into bash shell the job may get broken.

As we don't really know the reason behind this PowerShell decision, we suggest to create a new task/issue for this change.

Please let us know your comments. Thanks!

Copy link
Contributor

@damccorm damccorm Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we suggest to create a new task/issue for this change.

That's fine by me, this doesn't need to be blocking

run: |
sudo apt-get update
sudo apt-get install -y wget apt-transport-https software-properties-common
wget -q "https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb"
sudo dpkg -i packages-microsoft-prod.deb
sudo apt-get update
sudo apt-get install -y powershell
- shell: pwsh
name: get Difference
id: check_file_changed
Expand All @@ -60,7 +68,7 @@ jobs:
run: echo "${{ steps.check_has_example.outputs.example_has_changed }}"
deploy_examples:
name: Deploy examples
runs-on: ubuntu-latest
runs-on: [self-hosted, ubuntu-20.04]
needs: [ check_examples ]
if: needs.check_examples.outputs.example_has_changed == 'True'
steps:
Expand All @@ -71,8 +79,8 @@ jobs:
python-version: '3.8'
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '8'
distribution: 'zulu'
java-version: '8'
- name: Install kubectl
run: |
curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl" &&\
Expand Down