-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners #23162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners #23162
Conversation
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| - name: install deps | ||
| run: pip install -r requirements.txt | ||
| working-directory: playground/infrastructure | ||
| - name: Install PowerShell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than installing powershell, can we just convert the pwsh block below to a more generic script block? It isn't doing anything that a bash shell shouldn't be able to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we are adding the required installations to make the workflows work. In this case, we are afraid that by changing this block of code into bash shell the job may get broken.
As we don't really know the reason behind this PowerShell decision, we suggest to create a new task/issue for this change.
Please let us know your comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we suggest to create a new task/issue for this change.
That's fine by me, this doesn't need to be blocking
|
Status update: reviewed by @damccorm, waiting for the migration window to deploy the infrastructure and request the merge. |
* Switching trigger to pull_request * Removing ref from checkout
|
Reminder, please take a look at this pr: @Abacn |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
DO NOT MERGE until the infrastructure is in place. Please talk to @dannymartinm @elink21 before mergingAs part of the issue 21106, @elink21 and I have implemented the self-hosted runners for the Ubuntu and Windows operating systems.
Please see the Approved Pull Request (PR#22703) for reference.
In this PR you will find the following changes:
runs-onself-hosted runnersPR#16511 : Previous PR for reference.
BEAM-12812: Original Jira may contain additional context.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.