Skip to content

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Oct 18, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member Author

pabloem commented Oct 18, 2022

idk why samza tests run on Java Precommits...

@github-actions github-actions bot added the build label Oct 19, 2022
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

@fernando-wizeline is this something that your team already has a pr in flight for or is in progress? Want to make sure we're not duplicating work here

@fernando-wizeline
Copy link
Contributor

@fernando-wizeline is this something that your team already has a pr in flight for or is in progress? Want to make sure we're not duplicating work here

Hi Danny!
Yeah, it looks like the validatesRunner part is being worked on PR23267. The sickbay validation though is not.
Tagging @MarcoRob just to doublecheck.

@pabloem
Copy link
Member Author

pabloem commented Oct 19, 2022

ok great i can wait until #23267 goes in

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @damccorm

@damccorm
Copy link
Contributor

damccorm commented Nov 8, 2022

stop reviewer notifications

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Stopping reviewer notifications for this pull request: requested by reviewer

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Feb 9, 2023
@damccorm damccorm reopened this Feb 9, 2023
@damccorm damccorm added the pinned label Feb 9, 2023
@github-actions github-actions bot removed the stale label Feb 10, 2023
@damccorm damccorm closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants