GA Migration Java PostCommit ValidatesRunner (Flink, Flink Jv11, Samza, Twister2) #23267

MarcoRob · 2022-09-15T23:30:10Z

As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:

Migrated workflow job-postcommit-java-validaterunners-flink.yml
Migrated workflow job-postcommit-java-validaterunners-flink-java11.yml
Migrated workflow job-postcommit-java-validaterunners-samza.yml
Migrated workflow job-postcommit-java-validaterunners-twister2.yml

The migrated workflows were added to CI.md

DO NOT MERGE until the effort to use self-hosted runners is completed #22703
These workflows use base actions listed in #23109 (Dependency)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

github-actions · 2022-10-06T14:45:53Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions · 2022-10-14T12:14:22Z

Reminder, please take a look at this pr: @Abacn

.github/workflows/job-postcommit-java-validatesrunner-flink-java11.yml

.github/workflows/job-postcommit-java-validaterunners-samza.yml

github-actions · 2022-12-01T12:14:11Z

Reminder, please take a look at this pr: @Abacn

damccorm · 2022-12-02T18:12:12Z

.github/workflows/job-postcommit-java-validatesrunner-flink.yml

+      fail-fast: false
+      matrix:
+        flink-versions: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.FLINK_VERSIONS}}
+        exclude: # exclude other versions, we only need 1.13 for this test


We should do the same thing as in the other test if we only need 1.13 (use that as the version instead of an exclude list)

I recently bumped DataProc to 2.1 which runs flink 1.15. DataProc never supports flink 1.13 (Dataproc 2.0 runs flink 1.12)

@Abacn should we just be pinning to 1.15 across both suites? Probably?

yeah I would suggest. For Jenkins it is set here:

beam/.test-infra/jenkins/CommonTestProperties.groovy

Line 28 in e1cd5c4

static String getFlinkVersion() {

we could also define a single test version for Github Action.

Hi @damccorm
So for this workflow, should I use the 1.15 flink version instead of 1.13?

Yeah - could you actually set a FLINK_LATEST property to 1.15 here - https://github.com/apache/beam/blob/9b3b403ae9c071dcef0e801c892eab2203db88df/.github/actions/setup-default-test-properties/test-properties.json#LL17C48-L17C48 - and use that in both workflows?

Yeah I can apply the change, just I tested using 1.15 but the test failed, I changed back to 1.13 and the test passed. 🤔

@Abacn any ideas? https://github.com/MarcoRob/beam/actions/runs/3622938989/jobs/6108239170

I recently bumped DataProc to 2.1 which runs flink 1.15. DataProc never supports flink 1.13 (Dataproc 2.0 runs flink 1.12)

Does this actually affect this set of tests? Or are these just running on a local cluster? My guess is that its all local

No, that change does not affect local clusters. Running flink 1.13 on local cluster does not involve DataProc and does not have problem. For test failure not sure the cause, but we can defer the version aligning as future task if bumping version breaks test.

Change applied using Flink Version 1.13, I applied the following property as FLINK_DEFAULT_VERSION

codecov · 2022-12-02T19:44:31Z

Codecov Report

Merging #23267 (e1cd5c4) into master (8dea86b) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head e1cd5c4 differs from pull request most recent head 52e377f. Consider uploading reports for the commit 52e377f to get more accurate results

@@            Coverage Diff             @@
##           master   #23267      +/-   ##
==========================================
- Coverage   73.40%   73.37%   -0.03%     
==========================================
  Files         718      719       +1     
  Lines       95652    97206    +1554     
==========================================
+ Hits        70211    71323    +1112     
- Misses      24130    24536     +406     
- Partials     1311     1347      +36

Flag	Coverage Δ
go	`51.64% <ø> (+0.75%)`	⬆️
python	`82.98% <ø> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...python/apache_beam/examples/complete/distribopt.py	`0.00% <0.00%> (-98.57%)`	⬇️
...hon/apache_beam/examples/cookbook/mergecontacts.py	`23.21% <0.00%> (-73.22%)`	⬇️
...he_beam/examples/cookbook/multiple_output_pardo.py	`37.50% <0.00%> (-58.34%)`	⬇️
...python/apache_beam/examples/wordcount_debugging.py	`38.77% <0.00%> (-57.15%)`	⬇️
...python/apache_beam/examples/dataframe/wordcount.py	`38.46% <0.00%> (-53.85%)`	⬇️
...s/python/apache_beam/examples/wordcount_minimal.py	`40.74% <0.00%> (-51.86%)`	⬇️
sdks/python/apache_beam/examples/wordcount.py	`48.27% <0.00%> (-44.83%)`	⬇️
...apache_beam/examples/cookbook/custom_ptransform.py	`53.65% <0.00%> (-41.58%)`	⬇️
.../apache_beam/examples/cookbook/group_with_coder.py	`51.16% <0.00%> (-34.89%)`	⬇️
sdks/python/apache_beam/examples/complete/tfidf.py	`73.43% <0.00%> (-24.95%)`	⬇️
... and 159 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2023-02-11T12:44:42Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

pabloem · 2023-02-11T15:56:19Z

hmmm what should we do here @damccorm ?

damccorm · 2023-02-13T14:27:57Z

Lets leave this open for now so that we can take this effort forward if we're able to get the resources to do so.

github-actions bot added build infra labels Sep 15, 2022

MarcoRob added 12 commits September 28, 2022 10:22

job vr java flink

5de6b4b

job vr flink java 11

3bb8c9f

job vr samza

8a97c03

job vr twister2

0884693

job vr twister2

fbe2312

add global versioning for flink test

c47a3ab

fix yml config in twister job

234eb04

add missing java11 version for flink java 11 job

7f53709

apply minor fixes to workflows confign

02cc67f

resolve CI conflicts and fix

de5465c

remove jenkins jobs

33283b2

update runners for job

1cd3ab3

MarcoRob force-pushed the GABR-110-VR-flink-samza-twister branch from e954381 to 1cd3ab3 Compare September 28, 2022 15:29

MarcoRob added 5 commits September 28, 2022 10:30

add property to job yml

6b42594

remove submodules property

c07ae76

remove yml properties

41cd583

remove yml properties

ea4bd21

remove yml properties

2aa787c

MarcoRob marked this pull request as ready for review October 3, 2022 17:18

github-actions bot added the Next Action: Reviewers label Oct 6, 2022

MarcoRob added 2 commits October 6, 2022 12:43

remove letter

b6f4a41

remove step form workflow

b369e17

github-actions bot added the slow-review label Oct 14, 2022

damccorm reviewed Oct 14, 2022

View reviewed changes

.github/workflows/job-postcommit-java-validatesrunner-flink-java11.yml Outdated Show resolved Hide resolved

.github/workflows/job-postcommit-java-validatesrunner-flink-java11.yml Outdated Show resolved Hide resolved

damccorm removed Next Action: Reviewers slow-review labels Oct 14, 2022

damccorm added the Next Action: Author label Oct 14, 2022

fernando-wizeline mentioned this pull request Oct 19, 2022

Add GHA samza tests #23714

Closed

4 tasks

pabloem reviewed Oct 19, 2022

View reviewed changes

.github/workflows/job-postcommit-java-validaterunners-samza.yml Show resolved Hide resolved

fix workflow removing matrix and sleep

647fcea

github-actions bot added Next Action: Reviewers and removed Next Action: Author labels Nov 23, 2022

github-actions bot added the slow-review label Dec 1, 2022

damccorm reviewed Dec 2, 2022

View reviewed changes

damccorm added Next Action: Author and removed Next Action: Reviewers slow-review labels Dec 2, 2022

fix flink version for vr flink workflow

25f6bf7

github-actions bot added Next Action: Reviewers and removed Next Action: Author labels Dec 5, 2022

add default flink version

52e377f

damccorm approved these changes Dec 12, 2022

View reviewed changes

damccorm added Next Action: Author and removed Next Action: Reviewers labels Dec 12, 2022

github-actions bot added the stale label Feb 11, 2023

github-actions bot removed the stale label Feb 12, 2023

damccorm added the pinned label Feb 13, 2023

damccorm added Jenkins->Actions and removed pinned labels Apr 12, 2023

damccorm closed this Apr 12, 2023

GA Migration Java PostCommit ValidatesRunner (Flink, Flink Jv11, Samza, Twister2) #23267

GA Migration Java PostCommit ValidatesRunner (Flink, Flink Jv11, Samza, Twister2) #23267

Uh oh!

Conversation

MarcoRob commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Actions Tests Status (on master branch)

Uh oh!

github-actions bot commented Oct 6, 2022

Uh oh!

github-actions bot commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

damccorm Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 11, 2023

Uh oh!

pabloem commented Feb 11, 2023

Uh oh!

damccorm commented Feb 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MarcoRob commented Sep 15, 2022 •

edited

Loading

damccorm Dec 5, 2022 •

edited

Loading

codecov bot commented Dec 2, 2022 •

edited

Loading