-
Notifications
You must be signed in to change notification settings - Fork 4.5k
GA migration - Base actions to use for precommit and postcommit workflows #23109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Hi @damccorm, |
| name: 'Setup environment for self-hosted runners' | ||
| description: 'Setup action to run jobs in a self-hosted runner' | ||
|
|
||
| runs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some optional inputs like:
inputs:
requires-py-37:
required: false
default: 'true'
requires-py-38:
required: false
default: 'true'
requires-py-39:
required: false
default: 'true'
requires-java-8:
required: false
default: 'true'
requires-go-16:
required: false
default: 'true'
So that a given job can specify if it doesn't need some set of dependencies. I agree installing all of them by default is a good idea though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Danny!
We can definitely add those inputs to this action so that further workflows can make use of them.
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.