Skip to content

Conversation

@benEng
Copy link
Contributor

@benEng benEng commented Sep 8, 2022

As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:

  • An action to set up the SDKs versions in self-hosted runners.
  • An action to run a Gradle command with default arguments, copied from CommonJobProperties from Jenkins files
  • An action to setup default test properties (like SDKs versions) from a config file

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@fernando-wizeline
Copy link
Contributor

Hi @damccorm,
is this something you can help us to review?
Basically these base actions will support the workflows and needs to be merged before the rest of the workflows.
The changes introduced don't affect current Beam functionality so reviewing/merging shouldn't be much hassle.
Thanks!

name: 'Setup environment for self-hosted runners'
description: 'Setup action to run jobs in a self-hosted runner'

runs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some optional inputs like:

inputs:
  requires-py-37:
    required: false
    default: 'true'
  requires-py-38:
    required: false
    default: 'true'
  requires-py-39:
    required: false
    default: 'true'
  requires-java-8:
    required: false
    default: 'true'
  requires-go-16:
    required: false
    default: 'true'

So that a given job can specify if it doesn't need some set of dependencies. I agree installing all of them by default is a good idea though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Danny!
We can definitely add those inputs to this action so that further workflows can make use of them.

@benEng benEng mentioned this pull request Sep 14, 2022
4 tasks
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants