-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Split java precommit more #24584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split java precommit more #24584
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Yes, it is good a good point. If you are working on an I/O then it will not be a problem, because the "Java PreCommit" will not run, just the quick IO precommit. If you are working on the core SDK then yes it will create a large number of jobs because all the IOs trigger.
And yes I am just doing this now because the GHA migration is not done soon enough and this was pretty easy and should remove a lot of flaking, and let us re-run just certain pieces Long version: Before this PR we had the rules:
The rules I am implementing are:
This PR implements those rules directly:
We could also implement the rules with these jobs:
The benefit of having separate IO jobs is that if there is a flake the rerun can be just the IO job. |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed notes. This LGTM. "A big job" sounds good as well but given that we are going to move on to GitHub Action this change could be enough.
This splits most of the remaining IOs into their own precommit, and also fixes a few trigger paths here and there to really get to minimal testing. We will want to refactor this stuff later, I'm sure.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.