-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Disable triggering most IO_Direct precommit on buildSrc and core change #25612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
run seed job |
|
(seed job not triggering, currently jenkins is experience the issues described above, after another push of #24015 done 1 hr ago Update: seed job succeeded: https://ci-beam.apache.org/job/beam_SeedJob/11161/ |
|
I wonder if a better fix here is to consolidate some of our sharded precommits so that instead of having 1 precommit for IOs (our old state) or 21 precommits for IOs (our current state) we have a precommit per IO if the IO changes frequently and we have 1 precommit (or a few precommits) for the remaining relatively stable ones. A completely different alternative would be to have individual IO suites that trigger when that IOs directory is modified and 1 "mega IO" suite that triggers when we want to run all of our IO tests. That has the downside of getting out of sync more easily, but does what we want about as efficiently and precisely as possible. All of this is more of a test structure question for a set of suites I don't personally care a ton about, so I'll defer to you, other IO folks, and @kennknowles (who did the initial sharding, which has been a win IMO), but I don't love the idea of not running precommits that have the potential to break on dependency changes. I also acknowledge, though, that all of these solutions stink because the real solution is to actually fix the infrastructure (which probably means move to GHA for us), but that's not a realistic stopgap solution. |
15e0461 to
09988b7
Compare
|
run seed job |
09988b7 to
0d37bdd
Compare
|
run seed job Update: passed: https://ci-beam.apache.org/job/beam_SeedJob/11169/ |
|
Thanks @damccorm. Created a "mega" suite only for code change on buildSrc/core/io common; in addition to 21 io precommits on particular IOs |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach
|
I'm going to merging this as no further change request received. Summary: For Cron jobs or PR changes only involving specific IO, nothing changed For PR changes involving
Before: trigger all IO precommits After: build task of 21 IO precommits combined into a single precommit task |
…ge (apache#25612) * Disable triggering most IO_Direct precommit on buildSrc and core change * Add jobs to README * Create an umbrella IO job * Fix readme: IOs job does not have cron
It is found when reviewing #24015, whenever a new commit pushed, all (65) precommits are triggered at once and it simply causes Jenkins send too much GitHub API, in the following minutes:
Many of these "PreCommit" are splitted from old big JavaPreCommit (for unit test) and JavaPostCommit (for integration tests) #24584. Currently they are triggered automatically when the change is made on java core or buildSrc. I had the concern if this could cause problem when reviewing that PR, apparently it is true. Given that our build system cannot handle these number of PreCommit run at the same time, here I propose disable triggering most of these IO_Direct (21) precommit on buildSrc and core change.
The Con is that when there is a change on dependency version (handled by BeamModulePlugin) one needs to trigger the job by commenting on PR manually now. Considering that every precommit is running every 6 hr and there is another gate on release process (#25609) this should be fine.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.