[BEAM-222] Don't advance beyond last valid value #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @dhalperi |
Contributor
Author
|
R: @lukecwik |
| if (current >= numMessagesPerShard) { | ||
| if (current >= numMessagesPerShard - 1) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
should this be reordered below the if below it? Probably little harm.
Contributor
Author
There was a problem hiding this comment.
I prefer this order - if done early exit, if want to repeat repeat, otherwise advance to valid position.
Contributor
There was a problem hiding this comment.
yes. just confirming it's okay that you can't repeat the last element.
Contributor
|
LGTM |
dhalperi
pushed a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Apr 27, 2016
This is a (partial) backport of: apache/beam#132 apache/beam#235 apache/beam#248
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
added a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
Seq builder2
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* docs: adds UPGRADING.md, not to readme, to help inform users about migration to v2 * docs: erroneous version number * Update UPGRADING.md Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com> * docs: clarify enums statement * docs: add migration section to docs index Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there was a bug with allowing 'advanced beyond last element' to be a valid counter state.
Only an internal reload test caught it.
Included unit test for that case.