[BEAM-222] Respect checkpointing contract in TestCountingSource #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
test? |
Contributor
Author
|
I'm going to follow your advice in the issue and nuke this entirely. Stand by. |
Contributor
Author
|
It's Friday, I'm already 3 steps removed from the problem I set out to solve. |
Contributor
|
Looks like the test is flaky: from this log |
Contributor
|
Sorry, more accurately, looks like this may have caused a different test using this source to become flaky. |
| } else { | ||
| return false; | ||
| } | ||
| return current < numMessagesPerShard; |
Contributor
There was a problem hiding this comment.
the indentation looks off here, but maybe it's a tabs-vs-spaces thing? Except we shouldn't have tabs.. hmm.. can you please investigate?
added 4 commits
April 25, 2016 14:10
…st cirtainly would have resulting in global meltdown. Here's to you maven-checkstyle-plugin.
Contributor
Author
|
Fixed flaky test - it was a real bug that I introduced so that's good. |
Contributor
Author
|
R: @dhalperi |
| public void testRespectsCheckpointContract() throws IOException { | ||
| TestCountingSource source = new TestCountingSource(3); | ||
| PipelineOptions options = PipelineOptionsFactory.create(); | ||
| TestCountingSource.CountingSourceReader reader = source.createReader(options, null); |
Member
There was a problem hiding this comment.
null -> null /* no checkpoint */
| return current < numMessagesPerShard; | ||
| } | ||
|
|
||
| @Override |
Member
There was a problem hiding this comment.
Ensure that all the get/close calls ensure that start has been called.
Member
|
LGTM Need to fund getting rid of TestCountingSource in favor of CountingSource and having a test artifact |
Contributor
Author
|
Agree. On Mon, Apr 25, 2016 at 4:03 PM, lukecwik notifications@github.com wrote:
|
dhalperi
pushed a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Apr 27, 2016
This is a (partial) backport of: apache/beam#132 apache/beam#235 apache/beam#248
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-hbase] fix bulkloading
damccorm
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Feat: Adding composite and base job (#215) * Added python_release_candidate job. * Testing pr from rc_tag. * Adding GH_TOKEN env var * Set PR head as WORKING_BRANCH * Removed unused code. * Adding Run RC Validation job in CI.md doc file. * Removed Set Environment Variables step. Setting variables in env property. * Removed composite rc-validation action. * Rc validation workflow for Dataflow Taxi, Python Cross Validation and Runners (#227) * RC Validation Workflow (#228) Adding the following jobs: * sql_taxi_with_dataflow * python_cross_validation * generate_shared_pubsub * java_injector * direct_runner_leaderboard * dataflow_runner_leaderboard * direct_runner_gamestats * dataflow_runner_gamestats * remove_shared_pubsub * Adding extras jobs to CI.MD (#230) * Fixing workflow linter error (#231) * Using inputs in composite action (#235) * Using inputs in composite action Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added Verify Working Branch step. * Adding extras jobs to CI.MD (#230) Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* chore: release 2.0.0-dev2 * Update CHANGELOG.md, manually separate dev2 changes Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @dhalperi