Skip to content

Conversation

@amitsela
Copy link
Member

@amitsela amitsela commented Apr 22, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@amitsela
Copy link
Member Author

Replacing #226 because of the git mess I made there.
Using AutoService is more "Beamish" and got rid of a bunch of classes, so it looks good - Thanks @lukecwik and @dhalperi
Since this PR is completely different (except for the README part), please review, Thanks!

/**
* Test {@link SparkRunnerRegistrar}.
*/
public class SparkRunnerRegistrarTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please annotate class with:
@RunWith(JUnit4.class)

@lukecwik
Copy link
Member

Minor fix ups and then LGTM

@dhalperi
Copy link
Contributor

R: @lukecwik

(Nothing to add here.)

@asfgit asfgit closed this in 692f3a1 Apr 22, 2016
@amitsela amitsela deleted the BEAM-213 branch April 22, 2016 22:45
iemejia pushed a commit to iemejia/beam that referenced this pull request Jan 12, 2018
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
damccorm pushed a commit that referenced this pull request Oct 18, 2022
* Feat: Adding composite and base job (#215)

* Added python_release_candidate job.

* Testing pr from rc_tag.

* Adding GH_TOKEN env var

* Set PR head as WORKING_BRANCH

* Removed unused code.

* Adding Run RC Validation job in CI.md doc file.

* Removed Set Environment Variables step. Setting variables in env property.

* Removed composite rc-validation action.

* Rc validation workflow for Dataflow Taxi, Python Cross Validation and Runners (#227)

* RC Validation Workflow (#228)

Adding the following jobs:
* sql_taxi_with_dataflow
* python_cross_validation
* generate_shared_pubsub
* java_injector
* direct_runner_leaderboard
* dataflow_runner_leaderboard
* direct_runner_gamestats
* dataflow_runner_gamestats
* remove_shared_pubsub

* Adding extras jobs to CI.MD (#230)

* Fixing workflow linter error (#231)

* Using inputs in composite action (#235)

* Using inputs in composite action

Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>

* Added Verify Working Branch step.

* Adding extras jobs to CI.MD (#230)

Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com>
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants