-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-213] Fix README to use refactored package names and use AutoService for Registrar #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
| /** | ||
| * Test {@link SparkRunnerRegistrar}. | ||
| */ | ||
| public class SparkRunnerRegistrarTest { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please annotate class with:
@RunWith(JUnit4.class)
Member
|
Minor fix ups and then LGTM |
Contributor
|
R: @lukecwik (Nothing to add here.) |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-core] performance tuning
damccorm
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Feat: Adding composite and base job (#215) * Added python_release_candidate job. * Testing pr from rc_tag. * Adding GH_TOKEN env var * Set PR head as WORKING_BRANCH * Removed unused code. * Adding Run RC Validation job in CI.md doc file. * Removed Set Environment Variables step. Setting variables in env property. * Removed composite rc-validation action. * Rc validation workflow for Dataflow Taxi, Python Cross Validation and Runners (#227) * RC Validation Workflow (#228) Adding the following jobs: * sql_taxi_with_dataflow * python_cross_validation * generate_shared_pubsub * java_injector * direct_runner_leaderboard * dataflow_runner_leaderboard * direct_runner_gamestats * dataflow_runner_gamestats * remove_shared_pubsub * Adding extras jobs to CI.MD (#230) * Fixing workflow linter error (#231) * Using inputs in composite action (#235) * Using inputs in composite action Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added Verify Working Branch step. * Adding extras jobs to CI.MD (#230) Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.