[BEAM-22] Add withElements to CommittedBundle #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @bjchambers |
| } | ||
|
|
||
| @Override | ||
| public CommittedBundle<T> withElements(Iterable<WindowedValue<T>> elements) { |
Contributor
There was a problem hiding this comment.
I feel like this may need to inherit the synchronizedCompletionTime from the elements as well. Is that not the case?
Member
Author
There was a problem hiding this comment.
Noted why the current value is propagated in the CommittedBundle javadoc.
Move to a static nested class.
Contributor
|
One comment, then LGTM |
The unprocessed elements of a partially completed bundle must be placed in a new bundle to be processed at a later time. The bundle in which they are processed should also have identical properties to the bundle which the elements were initially present in. withElements provides a simple way to create a "copy" of a bundle that contains different elements.
tgroh
force-pushed
the
ippr_bundle_withelements
branch
from
b136933 to
2df419f
Compare
| * {@link #getElements()} will return the provided elements. This bundle is unchanged. | ||
| * | ||
| * <p> | ||
| * The value of {@link #getSynchronizedProcessingOutputWatermark()} of the returned |
Contributor
There was a problem hiding this comment.
The {@link #getSynchronizedProcessingOutputWatermark() synchronized processing watermark} of the returned...
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
Hadoop tuning
damccorm
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Feat: Adding composite and base job (#215) * Added python_release_candidate job. * Testing pr from rc_tag. * Adding GH_TOKEN env var * Set PR head as WORKING_BRANCH * Removed unused code. * Adding Run RC Validation job in CI.md doc file. * Removed Set Environment Variables step. Setting variables in env property. * Removed composite rc-validation action. * Rc validation workflow for Dataflow Taxi, Python Cross Validation and Runners (#227) * RC Validation Workflow (#228) Adding the following jobs: * sql_taxi_with_dataflow * python_cross_validation * generate_shared_pubsub * java_injector * direct_runner_leaderboard * dataflow_runner_leaderboard * direct_runner_gamestats * dataflow_runner_gamestats * remove_shared_pubsub * Adding extras jobs to CI.MD (#230) * Fixing workflow linter error (#231) * Using inputs in composite action (#235) * Using inputs in composite action Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> * Added Verify Working Branch step. * Adding extras jobs to CI.MD (#230) Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Also, drop fossil script (created with old name). Closes apache#227. Closes apache#228. Closes apache#229.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
When a bundle is partially completed, the unprocessed elements must be
placed in a new bundle to be processed at a later time. The bundle in
which they are processed should also have identical properties to the
bundle which the elements were initially present in.
withElements provides a simple way to create a "copy" of a bundle that
contains different elements.