Tourofbeam+infrastructure #24920
Closed
Tourofbeam+infrastructure #24920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24920 +/- ##
==========================================
- Coverage 72.82% 72.81% -0.02%
==========================================
Files 775 775
Lines 102948 102936 -12
==========================================
- Hits 74974 74953 -21
- Misses 26520 26528 +8
- Partials 1454 1455 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use credential for mongodb performance tests * Set cron job freq to twice a day as for other performance tests
Line 59 is using the flag `--inputText` which is different from the actual code repository which uses `--input-text`. Running the code with `--inputText` returns an error message `flag provided but not defined: -inputText` while running the code with `--input-text` returns the expected output ```markdown go run main.go --inputText="Greetings" ``` This is inconsistent with the code which named the flag as `input-text` instead of `inputText` as shown in the snippet found in [Line 24 of main.go](https://github.com/apache/beam-starter-go/blob/main/main.go#L24) ```go var ( input_text = flag.String("input-text", "default input text", "Input text to print.") ) ```
…ive default MEMORY_AND_DISK (closes apache#25737) (apache#25738)
Update README.md Update build.gradle.kts Update build.gradle.kts Update build.gradle.kts Update build.gradle.kts Update build.gradle.kts Update variables.tf Update main.tf Transforming to variable Update variables.tf Update variables.tf Update variables.tf Update main.tf Update main.tf Debugging gcloud command output to variable Update variables.tf Update variables.tf Update variables.tf Updating local exec to iam resource Update .gitignore PR comments related updates Add space at the end of TF files PR comments related updates Update unit_content.g.dart Update unit_content.g.dart Update unit_content.g.dart Delete .firebaserc Update .gitignore
…n/beam into tourofbeam+infrastructure
…n/beam into tourofbeam+infrastructure
Contributor
Author
|
Closed as new duplicated PR has been created to maintain clean commit history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resolves (to be updated)
Purpose of PR: Tour of Beam infrastructure spin-up (both Backend and Frontend) using Terraform and Kotlin Gradle scripts
R: @olehborysevych
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.