Replace more uses of ClassLoadingStrategy.Default.INJECTION
#25578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cushon
commented
Feb 21, 2023
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
R: @lukecwik |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Member
|
Run Java PreCommit |
Member
|
Run SQL_Java11 PreCommit |
Member
|
Run Java PreCommit |
Member
|
Run SQL_Java11 PreCommit |
cushon
force-pushed
the
rollforward
branch
2 times, most recently
from
f3c8f47 to
bd8d16c
Compare
Contributor
Author
Contributor
Author
|
The presubmits look OK except for |
Contributor
|
LGTM. |
Contributor
|
Run Java examples on Dataflow Java 17 |
Contributor
|
Retest this please |
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
* revert a change to the classloader used in RowCoderGenerator (apache#23210 (comment)) * don't use the lookup strategy for built-in JDK classes
This was referenced Jul 16, 2023
16 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation for Java 17+.
See "Supporting proxies on Java versions prior to 9 and past 10" in http://mydailyjava.blogspot.com/2018/04/jdk-11-and-proxies-in-world-past.html
Follow-up to: 98f1f75.
This is a roll-forward of 2b62912, which was reverted in cushon@b92600a
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.