[BEAM-115] Port batch Flink GroupByKey to GroupByKeyViaGroupByKeyOnly #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Window.Bound translator that matches Flink streaming. It depends on deprecated privileged methods of DoFn.ProcessContext. But this is the status quo for most runners anyhow, and we have a plan for migrating everything away from it. This restores windowing support to the batch runner, and opens the door to using GroupByKeyViaGroupByKeyOnly, for which Flink already has the needed capabilities.
The current Flink batch translation ignores windows. This is consistent with the requirements of GroupByKeyOnly. This change ports the runner to the expansion of GroupByKey to a GroupByKeyOnly operation followed by a GroupAlsoByWindow operation.
Member
Author
Member
Author
|
The missing piece is state. Obvious routes forward:
|
Contributor
|
I think adding elements are partitioned into key-groups by sorting, then the whole group of elements with the same key is passed to the |
Contributor
|
This is a somewhat bigger change, though. |
kennknowles
changed the title
Member
Author
|
Closing this in favor of nearer-term #291. |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-examples] better exception handling in SimpleWordCount and …
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
…#278) Restore undocumented classes after async split. Closes apache#277 Co-authored-by: Craig Labenz <craig.labenz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
These are some moderately useful preliminaries that came out of a quick attempt to try out the
RunnableOnServicetests with the Flink runner. The attempt got a bit stuck, but I figured these alteration might be useful either way.If you are curious, translation seems to just not be invoked in my configuration, which you can see in the next couple commits on my branch flink-integration