Skip to content

Conversation

@dhalperi
Copy link
Contributor

@dhalperi dhalperi commented May 3, 2016

The pre-commit wordcount test will confirm that this does not break the
Cloud Dataflow worker.

This resolves BEAM-168.

The pre-commit wordcount test will confirm that this does not break the
Cloud Dataflow worker.
@dhalperi
Copy link
Contributor Author

dhalperi commented May 3, 2016

R: @davorbonaci @lukecwik any reviewer will do. I manually verified that the WordCountIT test passed inside the linked Jenkins suite.

At the time of writing, 3/4 Travis matrix has passed. The fourth appears to have gone out to lunch while downloading Maven jars.

@davorbonaci
Copy link
Member

LGTM

@asfgit asfgit closed this in 9b9d73f May 3, 2016
@dhalperi dhalperi deleted the remove-deprecated branch May 3, 2016 22:42
iemejia pushed a commit to iemejia/beam that referenced this pull request Jan 12, 2018
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
…#278)

Restore undocumented classes after async split.

Closes apache#277

Co-authored-by: Craig Labenz <craig.labenz@gmail.com>
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
* docs: add documentation for documentsnapshot class

* chore: drop superseded docs fix

See PR apache#278.

Co-authored-by: Tres Seaver <tseaver@palladion.com>
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants