Skip to content

Conversation

@chamikaramj
Copy link
Contributor

@chamikaramj chamikaramj commented Aug 16, 2023

Wait for the transform service to start/stop in tests.

Start unique transform service instance per test task.

Cleanup transform service temp directory after during the clanup phase of the test task.

Make sure to build the external SDK harnesses referred to by the transform service.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #28039 (0254cf0) into master (c7b7921) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28039      +/-   ##
==========================================
- Coverage   72.30%   72.30%   -0.01%     
==========================================
  Files         678      678              
  Lines       99744    99744              
==========================================
- Hits        72124    72121       -3     
- Misses      26058    26061       +3     
  Partials     1562     1562              
Flag Coverage Δ
python 82.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@chamikaramj chamikaramj force-pushed the transform_service_test_suite_wait_for_service branch from 4499d02 to 357198f Compare August 16, 2023 22:39
@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@chamikaramj chamikaramj force-pushed the transform_service_test_suite_wait_for_service branch from 357198f to eea700b Compare August 16, 2023 22:50
@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@chamikaramj chamikaramj force-pushed the transform_service_test_suite_wait_for_service branch from eea700b to 6fb173d Compare August 16, 2023 23:46
@chamikaramj
Copy link
Contributor Author

Run TransformService_Direct PostCommit

@chamikaramj chamikaramj requested a review from Abacn August 17, 2023 00:47
@chamikaramj chamikaramj mentioned this pull request Aug 17, 2023
3 tasks
@damccorm damccorm mentioned this pull request Aug 17, 2023
3 tasks
@chamikaramj chamikaramj force-pushed the transform_service_test_suite_wait_for_service branch from 6fb173d to 0254cf0 Compare August 17, 2023 21:26
@chamikaramj
Copy link
Contributor Author

R: @Abacn or @damccorm :)

This should fix the perma red new test suite https://ci-beam.apache.org/job/beam_PostCommit_TransformService_Direct/

@chamikaramj
Copy link
Contributor Author

Run Java_Pulsar_IO_Direct PreCommit

@chamikaramj
Copy link
Contributor Author

Run Portable_Python PreCommit

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, commented below

}

// Transform service delivers transforms that refer to SDK harness containers with following sufixes.
def transformServiceJavaContainerSuffix = 'java11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what caused this test requiring two java/python containers to work? Could it be able to clean up to make the test working for single java / py sdk container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this setup method is (or rather will be) shared by PythonFromJava and JavaFromPython tests.

For external transforms, Transform Service will require Python3.8 and Java11 containers (transformServicePythonContainerSuffix and transformServiceJavaContainerSuffix).

The pipeline SDK, we could run tests with multiple Java and Python versions hence we have to build such containers based on the test ( pythonContainerSuffix and javaContainerSuffix).

For example, currently BT test is run using Python3.8 and 3.11 for pipeline SDK and Java 11 for external SDK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I see, for a single slang test, there are at least two SDK container is working

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though it is generally nice to have these version not hard coded)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Beam ships with these specific versions (Python 3.8 and Java 11) of expansion service containers. I hope to add documentation on developing expansion service containers with additional language versions for users who need that.

@chamikaramj chamikaramj merged commit 26b7772 into apache:master Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants