-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Better manage transform service lifecycle for tests #28039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better manage transform service lifecycle for tests #28039
Conversation
|
Run TransformService_Direct PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #28039 +/- ##
==========================================
- Coverage 72.30% 72.30% -0.01%
==========================================
Files 678 678
Lines 99744 99744
==========================================
- Hits 72124 72121 -3
- Misses 26058 26061 +3
Partials 1562 1562
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run TransformService_Direct PostCommit |
4499d02 to
357198f
Compare
|
Run TransformService_Direct PostCommit |
357198f to
eea700b
Compare
|
Run TransformService_Direct PostCommit |
eea700b to
6fb173d
Compare
|
Run TransformService_Direct PostCommit |
6fb173d to
0254cf0
Compare
|
This should fix the perma red new test suite https://ci-beam.apache.org/job/beam_PostCommit_TransformService_Direct/ |
|
Run Java_Pulsar_IO_Direct PreCommit |
|
Run Portable_Python PreCommit |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, commented below
| } | ||
|
|
||
| // Transform service delivers transforms that refer to SDK harness containers with following sufixes. | ||
| def transformServiceJavaContainerSuffix = 'java11' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what caused this test requiring two java/python containers to work? Could it be able to clean up to make the test working for single java / py sdk container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this setup method is (or rather will be) shared by PythonFromJava and JavaFromPython tests.
For external transforms, Transform Service will require Python3.8 and Java11 containers (transformServicePythonContainerSuffix and transformServiceJavaContainerSuffix).
The pipeline SDK, we could run tests with multiple Java and Python versions hence we have to build such containers based on the test ( pythonContainerSuffix and javaContainerSuffix).
For example, currently BT test is run using Python3.8 and 3.11 for pipeline SDK and Java 11 for external SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. I see, for a single slang test, there are at least two SDK container is working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(though it is generally nice to have these version not hard coded)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Beam ships with these specific versions (Python 3.8 and Java 11) of expansion service containers. I hope to add documentation on developing expansion service containers with additional language versions for users who need that.
Wait for the transform service to start/stop in tests.
Start unique transform service instance per test task.
Cleanup transform service temp directory after during the clanup phase of the test task.
Make sure to build the external SDK harnesses referred to by the transform service.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.