[BEAM-22] Enable RunnableOnService Tests #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgroh
force-pushed
the
enable_ros_tests
branch
9 times, most recently
from
e8255cf to
e4fc8b4
Compare
Member
Author
|
Takes ~1.5m to build the direct runner + run the additional RunnableOnService Tests on Jenkins; about 2-3 on the slower travis targets. |
Member
Author
|
R: @kennknowles |
Member
|
Nice. Since we will, afterwards, be removing the test runs of the current |
Member
|
It does seem that the cost on travis is much greater. |
Member
|
You can actually do the disabling of redundant tests in this PR by adding |
Reduces the number of active threads, which should improve scheduling behavior. Additionally improves caching behavior of ParDo evaluators due to increased reuse of DoFns.
Explicitly remove beamTestPipelineOptions in examples. Otherwise, running the examples after a PipelineRunner with
With the direct runner executing all of this category (in runners/direct-java), we maintain this test coverage without running these tests while building the Core SDK. Required to remove the legacy direct runner.
Member
|
LGTM. I think it is time to merge this. |
4 tasks
dhalperi
added a commit
to dhalperi/beam
that referenced
this pull request
Aug 23, 2016
Add UnboundedCountingInput#withRate
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* chore: manual synth * ran synthtool to add bundle proto definitions * beginning of bundle implementation added methods to assemble bundles, but not yet serialize them into length-prefixed json strings with tests for bundle assembly * linting * Added bundle build method * fixed incomplete document id * fixed git merge error * Added first draft of docstrings * Added FirestoreBundle deserialization * Fixed import desync * Improved test coverage for bundles * linting * test coverage * CI happiness * converted redundant exception to assertion * removed todo * Updated comments * linted * Moved query limit type into bundle code * Added typed response for parsing reference values * refactored document reference parsing * removed auto import of bundles from firestore * small tweaks * added tests for document iters * Updated FirestoreBundle imports and synthtool gen * linting * extra test coverage * responses to code review * linting * Fixed stale docstring * camelCased bundle output * updated stale comments * Added test for binary data * linting Co-authored-by: Craig Labenz <craiglabenz@google.com> Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Not ready for review. Publishing PR to hook into Travis and Jenkins.
Update runners/direct-java/pom.xml to enable the RunnableOnService
tests phase.