[BEAM-22] Cache SideInput contents in InProcessSideInputContainer #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that while processing a bundle all elements see the same contents for any SideInput Window.
Member
Author
|
R: @kennknowles |
Member
|
Code LGTM. Will merge when green. Testing changing contents underneath the evaluator is probably better than just checking readiness, but this improves the testing status quo so I say move forward. |
4 tasks
dhalperi
pushed a commit
to dhalperi/beam
that referenced
this pull request
Aug 23, 2016
Generally more stable, plus bulk writes bring 5x write throughput in batch jobs by more efficiently using the network.
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pabloem
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Extract and load Beam symbols (#23304) * Move a file (#23304) * Move a file (#23304) * Update Playground frontend README (#23304) * Update Playground fronten pubspec.lock (#23304) * Add the licence (#23304) * Fix after review (#23304) * Add tests for SymbolsNotifier and YamlSymbolsLoader (#23304) * Fix after review (#23304) * Update README, move symbols from python.yaml to python.g.yaml (#23304) * Test extract_symbols_python.py, exclude generated files from rat check (#23304) * Pass extracted symbols to the editor (#23304) * Version-control generated files of Playground Frontend (#23534) * Minor fixes (#23534) * Extract Beam symbols for Go SDK (#23917) (#326) * Extract Beam symbols for Go SDK (#23917) * Fix after review, add tests (#23917) * Fix tests, lazy symbols loading on SDK switch (#23917) * Add newly generated files, add config.example.dart (#23304) * Fix (#23304) * gofmt extract_symbols_go.go (#23304) * Fix pythonG and goG falling out of generated asset constants (#23304) * Update flutter_code_editor to v0.1.9, pale read-only blocks (#23304)
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This ensures that while processing a bundle all elements see the same
contents for any SideInput Window.