Skip to content

Conversation

@sjvanrossum
Copy link
Contributor

Use endOffsets instead of seekToEnd and position to determine the backlog element size in KafkaUnboundedReader and ReadFromKafkaDoFn. Determining the end offsets by seeking and retrieving the position may trigger poll and prefetch records which will never be consumed by the offset consumer.

Forcibly retrieving the partition's high watermark in offset consumers might not be necessary, but this will be addressed separately.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@sjvanrossum sjvanrossum changed the title Determine partition backlog using endOffsets instead of seek2End and position [KafkaIO] Determine partition backlog using endOffsets instead of seek2End and position Oct 24, 2024
@Abacn
Copy link
Contributor

Abacn commented Oct 25, 2024

Hi, have you been able to get a KafkaIO reviewer? Reviewbot possibly needs a Kafka label.

Copy link
Contributor

@johnjcasey johnjcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run this version and see if we see the sawtooth backlog pattern, or if this resolves that issue?

@johnjcasey
Copy link
Contributor

LGTM.

@johnjcasey johnjcasey merged commit deeddd1 into apache:master Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants