-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[KafkaIO] Determine partition backlog using endOffsets instead of seek2End and position #32889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f6f67bb to
0edb636
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
8ae8b79 to
fd8820a
Compare
84e07a7 to
5593321
Compare
5593321 to
e9bddc9
Compare
|
Hi, have you been able to get a KafkaIO reviewer? Reviewbot possibly needs a Kafka label. |
johnjcasey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run this version and see if we see the sawtooth backlog pattern, or if this resolves that issue?
...sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTestTable.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java
Show resolved
Hide resolved
|
LGTM. |
Use
endOffsetsinstead ofseekToEndandpositionto determine the backlog element size inKafkaUnboundedReaderandReadFromKafkaDoFn. Determining the end offsets by seeking and retrieving the position may triggerpolland prefetch records which will never be consumed by the offset consumer.Forcibly retrieving the partition's high watermark in offset consumers might not be necessary, but this will be addressed separately.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.