-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[KafkaIO] Share size and offset estimators among ReadFromKafkaDoFn instances per PTransform #32928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c85f4aa to
a31a263
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
7f5930f to
eadde14
Compare
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
LGTM, please fix the conflicts and this should be good to go |
|
Done, should be good to go once #32921 is merged. |
e124d84 to
22a6bd0
Compare
b98b11f to
b7d86c3
Compare
|
@johnjcasey rebased and updated where required. @Abacn any thoughts? |
|
Run Spotless PreCommit |
|
Not sure why the check overview doesn't update. |
The UI is misleading. It's a GitHub bug and isn't an actual failure. It's due to some actions in workflow publish check back, but it does not name the report, and it's goes to a random workflow. |
b7d86c3 to
fef6ea8
Compare
|
Run Spotless PreCommit |
This change adds shared caches among unique instances of
ReadFromKafkaDoFn, identified by a staticAtomicLongwhich is stored as an instance field and incremented during construction of theDoFn. The constructor is bypassed during deserialization at execution time, thus providing a shared identifier for all instances ofReadFromKafkaDoFnfor a single transform.Note: this PR is stacked on top of #32921, #32920 and #32889
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.